[TIMOB-19009] Windows: Populate default ti.windows.publishername property value
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | Critical |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2015-06-23T14:48:35.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Release 4.1.0 |
| Components | Tooling, Windows |
| Labels | n/a |
| Reporter | Christopher Williams |
| Assignee | Christopher Williams |
| Created | 2015-06-12T14:22:10.000+0000 |
| Updated | 2015-06-24T18:10:08.000+0000 |
Description
It looks like we now require a new property to populate the user's appx.manifest and to use for certs on store apps.
Since it is required now, we should try and at least generate a sensible default value for the user in their tiapp.xml during project creation - or warn the user and use a generated one when we build?
It's a bad experience to just fail first build, spit out some error about needing to set the value and then hope the user follows it.
We could do a "create.post.app" hook in the CLI to edit the tiapp.xml and push a value in there. We could fall back to generating one if there is no value and give a warning to the user but continue?
<property name="ti.windows.publishername" type="string">CN=Dawson Toth</property>
From [~dtoth]: We could also infer a sane value based on the
<publisher />, if they haven't provided that windows property.We'd need to ensure we sanitized that value, since I know commas in it break the cert code. Not sure if there are other special characters we'd need to escape.https://github.com/appcelerator/titanium_mobile_windows/pull/309
Verified the implementation. App builds successfully with out specifying the
peoperty in the tiapp.xml Environment: Appc Studio: 4.1.0.201506221807 Ti SDK: 4.1.0.v20150624102755 Ti CLI: 4.0.1 Alloy: 1.6.2 Windows: 8.1 Enterprise 64-bit APPC NPM: 4.1.0-1 APPC CLI: 4.1.0-3 Device: Nokia Lumia 928 - Windows Phone 8.1