Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-19025] Windows: Build fails if the ti.windows.publishername is not present

GitHub Issuen/a
TypeBug
PriorityNone
StatusClosed
ResolutionFixed
Resolution Date2015-06-23T14:48:17.000+0000
Affected Version/sRelease 4.1.0
Fix Version/sRelease 4.1.0
ComponentsWindows
Labelsqe-4.1.0
ReporterEwan Harris
AssigneeChristopher Williams
Created2015-06-15T18:24:39.000+0000
Updated2015-06-24T18:56:34.000+0000

Description

Description

When building a Windows platform project if the property <property name="ti.windows.publishername" type="string">CN=Ewan Harris</property> is not defined then the build will error out with the below
C:\ProgramData\Titanium\mobilesdk\win32\4.1.0.v20150614181235\windows\cli\commands\_build.js:1703
                        publisherName: this.cli.tiapp.properties['ti.windows.publishername'].value,
                                                                                            ^
TypeError: Cannot read property 'value' of undefined
    at WindowsBuilder.generateCmakeList (C:\ProgramData\Titanium\mobilesdk\win32\4.1.0.v20150614181235\windows\cli\commands\_build.js:1703:72)
    at C:\ProgramData\Titanium\mobilesdk\win32\4.1.0.v20150614181235\node_modules\node-appc\node_modules\async\lib\async.js:610:21
    at C:\ProgramData\Titanium\mobilesdk\win32\4.1.0.v20150614181235\node_modules\node-appc\node_modules\async\lib\async.js:249:17
    at iterate (C:\ProgramData\Titanium\mobilesdk\win32\4.1.0.v20150614181235\node_modules\node-appc\node_modules\async\lib\async.js:149:13)
    at C:\ProgramData\Titanium\mobilesdk\win32\4.1.0.v20150614181235\node_modules\node-appc\node_modules\async\lib\async.js:160:25
    at C:\ProgramData\Titanium\mobilesdk\win32\4.1.0.v20150614181235\node_modules\node-appc\node_modules\async\lib\async.js:251:21
    at C:\ProgramData\Titanium\mobilesdk\win32\4.1.0.v20150614181235\node_modules\node-appc\node_modules\async\lib\async.js:615:34
    at WindowsBuilder.generateModuleFinder (C:\ProgramData\Titanium\mobilesdk\win32\4.1.0.v20150614181235\windows\cli\commands\_build.js:1614:2)
    at C:\ProgramData\Titanium\mobilesdk\win32\4.1.0.v20150614181235\node_modules\node-appc\node_modules\async\lib\async.js:610:21
    at C:\ProgramData\Titanium\mobilesdk\win32\4.1.0.v20150614181235\node_modules\node-appc\node_modules\async\lib\async.js:249:17

Steps To Reproduce

1. Create a new project 2. Build the project

Actual Result

The build will error out with the above error

Expected Result

The build should not error out

Comments

  1. Christopher Williams 2015-06-23

    https://github.com/appcelerator/titanium_mobile_windows/pull/309
  2. Lokesh Choudhary 2015-06-24

    Verified the fix. Closing as the related tickets provide the fix for this as well. Now we do not have to manually specify the publisher name. Environment: Appc Studio: 4.1.0.201506221807 Ti SDK: 4.1.0.v20150624102755 Ti CLI: 4.0.1 Alloy: 1.6.2 Windows: 8.1 Enterprise 64-bit APPC NPM: 4.1.0-1 APPC CLI: 4.1.0-3 Device: Nokia Lumia 928 - Windows Phone 8.1

JSON Source