[TIMOB-19180] Windows: Module creation fails due to CMake error: Could NOT find JavaScriptCore

GitHub Issue	n/a
Type	Bug
Priority	High
Status	Closed
Resolution	Fixed
Resolution Date	2015-07-08T08:11:17.000+0000
Affected Version/s	Release 4.1.0
Fix Version/s	n/a
Components	Windows
Labels	qe-4.1.0
Reporter	Ewan Harris
Assignee	Gary Mathews
Created	2015-07-06T22:12:28.000+0000
Updated	2017-03-16T22:08:13.000+0000

Description

When creating a module if JavascriptCore is not present on the system then the creation will fail with the below

CMake Error at C:/ProgramData/Titanium/mobilesdk/win32/4.1.0.v20150706111546/windows/cli/vendor/cmake/share/cmake-3.1/Modules/FindPackageHandleStandar
dArgs.cmake:138 (message):
  Could NOT find JavaScriptCore (missing: JavaScriptCore_INCLUDE_DIRS
  JavaScriptCore_LIBRARIES)
Call Stack (most recent call first):
  C:/ProgramData/Titanium/mobilesdk/win32/4.1.0.v20150706111546/windows/cli/vendor/cmake/share/cmake-3.1/Modules/FindPackageHandleStandardArgs.cmake:3
74 (_FPHSA_FAILURE_MESSAGE)
  cmake/FindJavascriptCore.cmake:55 (find_package_handle_standard_args)
  CMakeLists.txt:39 (find_package)
ERROR  | titanium exited with non-zero exit code (1)

Steps to reproduce

1. Ensure there is no JavascriptCore on your system 2. Create a module using appc new

Actual result

The creation will fail due to no JavascriptCore

Expected result

The creation should not fail

Comments

Gary Mathews 2015-07-07

PR: https://github.com/appcelerator/titanium_mobile_windows/pull/363
Lee Morris 2017-03-16

Closing ticket as fixed.

JSON Source