Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-19296] iOS9: Update image related methods to support the use of assets catalogs

GitHub Issuen/a
TypeTechnical task
PriorityHigh
StatusClosed
ResolutionFixed
Resolution Date2015-10-01T04:00:26.000+0000
Affected Version/sn/a
Fix Version/sRelease 5.1.0
ComponentsiOS
Labelsappthinning
ReporterChee Kiat Ng
AssigneeChee Kiat Ng
Created2015-07-31T03:09:59.000+0000
Updated2015-10-30T20:34:41.000+0000

Description

Currently, titanium image related methods expect a local or remote url. Assets catalog work by finding the image based on just the name of the image. So we have to modify the methods such that, it will first check if the assets catalog exist and contains the image, if it doesn't, then it will proceed as usual to treat it as a local or remote url.

Comments

  1. Chee Kiat Ng 2015-08-04

    PR: https://github.com/appcelerator/titanium_mobile/pull/7004
  2. Chee Kiat Ng 2015-08-17

  3. Chee Kiat Ng 2015-09-30

  4. Chee Kiat Ng 2015-09-30

    Test cases

    You can test these in KitchenSink Project 1. Imageview should still be able to load blob (BaseUI/View/Image Views/Image Blob) 2. Imageview should still be able to load remote url (BaseUI/View/Image Views/Basic) 3. Imageview should be able to load TiFile (BaseUI/View/Image Views/Image File) 4. Imageview should be able to load local image (Controls/Picker/Picker custom images) 5. Imageview should be able to animate files (BaseUI/View/Image Views/Animated) 6. Imageview should be able to load gif files (not in asset catalog) (BaseUI/View/Image Views/Animated) 7. controls should be able to show images (everything in kitchen sink from tab bar to buttons) 8. image view should load downloaded images (not in asset catalog) (BaseUI/View/Image Views/Image Blob) Outside of KitchenSink, in a new project: 1. Test if changing images while keeping the same file name is shown in subsequent builds. For app thinning testing, refer to parent ticket, and use Fokke's sample app.
  5. Eric Wieber 2015-10-30

    Verified implemented, using: MacOS 10.11.2 (15C27e) Studio 4.4.0.201510290507 Ti SDK 5.1.0.v20151028190028 Appc NPM 4.2.1 Appc CLI 5.1.0-38 Ti CLI 5.0.5 Alloy 1.7.16 Arrow 1.3.13 Xcode 7.2 (7C46l) Node v0.12.7 Java 1.7.0_80 production All KitchenSink tests above passed, asset catalog is successfully created, and the sample app from the parent ticket was successfully thinned.

JSON Source