[TIMOB-19437] Android: Null passed to putExtra() causes app to crash
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Critical |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2015-08-31T18:43:27.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Release 5.0.0 |
| Components | Android |
| Labels | n/a |
| Reporter | Tim Poulsen |
| Assignee | Hieu Pham |
| Created | 2015-08-18T15:17:01.000+0000 |
| Updated | 2017-03-22T22:41:32.000+0000 |
Description
Creating a separate ticket for my comments on TIMOB-18098.
PR https://github.com/appcelerator/titanium_mobile/pull/6958
Our app crashes frequently when the it's woken from the background by the user tapping a push notification. We are using the http://iamyellow.net/post/40100981563/gcm-appcelerator-titanium-module GCM module.
06-30 14:06:51.234: W/System.err(19120): java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.Class java.lang.Object.getClass()' on a null object reference
06-30 14:06:51.234: W/System.err(19120): at org.appcelerator.titanium.proxy.IntentProxy.putExtra(IntentProxy.java:198)
06-30 14:06:51.234: W/System.err(19120): at org.appcelerator.kroll.runtime.v8.V8Runtime.nativeRunModule(Native Method)
06-30 14:06:51.234: W/System.err(19120): at org.appcelerator.kroll.runtime.v8.V8Runtime.doRunModule(V8Runtime.java:177)
06-30 14:06:51.234: W/System.err(19120): at org.appcelerator.kroll.KrollRuntime.handleMessage(KrollRuntime.java:299)
06-30 14:06:51.234: W/System.err(19120): at org.appcelerator.kroll.runtime.v8.V8Runtime.handleMessage(V8Runtime.java:203)
06-30 14:06:51.234: W/System.err(19120): at android.os.Handler.dispatchMessage(Handler.java:98)
06-30 14:06:51.234: W/System.err(19120): at android.os.Looper.loop(Looper.java:145)
06-30 14:06:51.234: W/System.err(19120): at org.appcelerator.kroll.KrollRuntime$KrollRuntimeThread.run(KrollRuntime.java:112)
@Kroll.method
public void putExtra(String key, Object value)
{
if (value == null) {
return;
}
...
Closing ticket as fixed.