[TIMOB-19644] Windows: CLI build error is ignored

GitHub Issue	n/a
Type	Bug
Priority	Medium
Status	Closed
Resolution	Fixed
Resolution Date	2015-09-30T13:20:38.000+0000
Affected Version/s	Release 5.0.0
Fix Version/s	Release 5.1.0
Components	Windows
Labels	n/a
Reporter	Kota Iguchi
Assignee	Kota Iguchi
Created	2015-09-30T09:36:14.000+0000
Updated	2015-10-26T22:01:44.000+0000

Description

When there's no DefaultIcon.png, CLI shows critical error on build but it does not stop build process.

Comments

Kota Iguchi 2015-09-30

https://github.com/appcelerator/titanium_mobile_windows/pull/444

Lokesh Choudhary 2015-10-26

Verified the fix. If the defaulticon.png is not present in the project we get the error:

   [ERROR] :  There are missing app icons
   [ERROR] :  You must either create the missing icons below or create an image named "DefaultIcon-windows.png" or "DefaultIcon.png" in the root of your project
   [ERROR] :  If the DefaultIcon.png image is present, the build will use it to generate all missing icons
   [ERROR] :  It is highly recommended that the DefaultIcon.png be 1024x1024
   [ERROR] :  Unable to create missing icons:
   [ERROR] :    Square44x44Logo.png - Used for logo - required size: 44x44
   [ERROR] :    Square71x71Logo.png - Used for logo - required size: 71x71
   [ERROR] :    Square150x150Logo.png - Used for logo - required size: 150x150
   [ERROR] :  An error occurred during build after 2s 56ms

Environment: Appc Studio: 4.4.0.201510231805 Ti SDK: 5.1.0.v20151023172822 Ti CLI: 5.0.5 Alloy: 1.7.16 Windows: 8.1 Enterprise 64-bit APPC NPM: 4.2.1-6 APPC CLI: 5.1.0-38 Node : v0.12.7 Device: Nokia Lumia 928 - Windows Phone 8.1

JSON Source