[TIMOB-19680] iOS: Building aborts during icon set creation without reason

GitHub Issue	n/a
Type	Improvement
Priority	Critical
Status	Closed
Resolution	Fixed
Resolution Date	2015-10-07T03:45:40.000+0000
Affected Version/s	Release 5.1.0
Fix Version/s	Release 5.1.0
Components	n/a
Labels	qe-5.1.0
Reporter	Eric Wieber
Assignee	Chris Barber
Created	2015-10-06T21:47:03.000+0000
Updated	2015-10-12T20:34:16.000+0000

Description

When building a project for iOS (sim, device, or store) the process aborts while creating the icon set. A warning for an icon's alpha channel is shown, but no error or definie reason is given for the build to fail. See below console output:

[INFO]  Creating app icon set
[DEBUG] Writing /Users/ewieber/THISTOO/build/iphone/Assets.xcassets/Contents.json
[DEBUG] Unsupported app icon Resources/iphone/appicon-60.png, skipping
[WARN]  Skipping Resources/iphone/appicon-60@2x.png because app icons must not have an alpha channel
TRACE  | titanium exited with exit code 0
  appc:run signal received +31s exit sending to ChildProcess {
  domain: null,
  _events: { close: [Function] },
  _eventsCount: 1,
  _maxListeners: undefined,
  _closesNeeded: 1,
  _closesGot: 1,
  connected: false,
  signalCode: null,
  exitCode: 0,
  killed: false,
  spawnfile: '/usr/local/bin/node',
  _handle: null,
  spawnargs: 
   [ '/usr/local/bin/node',
     '/Users/ewieber/.appcelerator/install/5.0.2/package/bin/appc',
     'run',
     '-p',
     'ios',
     '-T',
     'device',
     '-l',
     'trace' ],
  pid: 3527,
  stdin: null,
  stdout: null,
  stderr: null,
  stdio: [ null, null, null ] }

*Steps to reproduce issue* 1. Create a new native alloy project with appc new 2. Build that project with appc run -p ios *Actual Results* The above output is shown and the process quits during icon set creation *Expected Results* The build succeeds or a clear reason for a failure is given. *Notes* This could also be a bug. If builds fail when there is a 32-but image, then we should not include any in our default projects.

Comments

Chee Kiat Ng 2015-10-07

[~cbarber] is this valid? I thought

   [WARN]  Skipping Resources/iphone/appicon-60@2x.png because app icons must not have an alpha channel

was reason enough :P

Chris Barber 2015-10-07

Found a bug. It was throwing an error instead of returning. This causes the build to fail out instead of continue. Master PR: https://github.com/appcelerator/titanium_mobile/pull/7272
Chee Kiat Ng 2015-10-07

Approved. PR merged.

Harry Bryant 2015-10-12

Verified as fixed, Created a new native alloy project with appc new & built the project with appc run -p ios . Project was built and launched successfully on simulator & device:

   [INFO]  Creating Xcode project
   [INFO]  Creating Entitlements.plist
   [INFO]  Creating Info.plist
   [INFO]  Disabling ATS
   [INFO]  Creating main.m
   [INFO]  Creating Xcode config files
   [INFO]  Copying Titanium libraries
   [INFO]  Copying Titanium iOS files
   [INFO]  Cleaning Xcode derived data
   [INFO]  Creating debugger and profiler plists
   [INFO]  Analyzing Resources directory
   [INFO]  Analyzing platform files
   [INFO]  Analyzing module files
   [INFO]  Analyzing localized launch images
   [INFO]  Analyzing CommonJS modules
   [INFO]  Creating asset catalog
   [INFO]  Creating app icon set
   [WARN]  Skipping Resources/iphone/appicon-60@2x.png because app icons must not have an alpha channel
   [WARN]  Skipping Resources/iphone/appicon-60@3x.png because app icons must not have an alpha channel
   [WARN]  Skipping Resources/iphone/appicon-76.png because app icons must not have an alpha channel
   [WARN]  Skipping Resources/iphone/appicon-76@2x.png because app icons must not have an alpha channel
   [WARN]  Skipping Resources/iphone/appicon-Small-40.png because app icons must not have an alpha channel
   [WARN]  Skipping Resources/iphone/appicon-Small-40@2x.png because app icons must not have an alpha channel
   [WARN]  Skipping Resources/iphone/appicon-Small.png because app icons must not have an alpha channel
   [WARN]  Skipping Resources/iphone/appicon-Small@2x.png because app icons must not have an alpha channel
   [INFO]  Creating launch image set
   [INFO]  Creating assets image set
   [INFO]  Processing JavaScript files
   [INFO]  Writing app properties
   [INFO]  Encrypting JavaScript files
   [INFO]  Writing i18n files
   [INFO]  Processing Titanium symbols
   [INFO]  Removing files
   [INFO]  Invoking xcodebuild
   [INFO]  Finished building the application in 1m 48s 558ms
   [INFO]  Launching iOS Simulator
   }

OSX El Capitan 10.11 Ti SDK: 5.2.0.v20151009071418 Appc NPM: 4.2.1-1 Appc CLI: 5.1.0-38

JSON Source