Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-19692] KitchenSink: Make KitchenSink work for auto layout and refactor outdated methods

GitHub Issuen/a
TypeStory
PriorityHigh
StatusClosed
ResolutionDone
Resolution Date2016-08-04T03:00:04.000+0000
Affected Version/sn/a
Fix Version/sRelease 5.4.0
ComponentsiOS
Labelsn/a
ReporterChee Kiat Ng
AssigneeAngel Petkov
Created2015-10-09T05:49:36.000+0000
Updated2016-08-04T03:00:04.000+0000

Description

KitchenSink https://github.com/appcelerator/KitchenSink *master branch* is a comprehensive test suite for UI-related components and views, but it's been outdated. We should fix certain things to make sure it works with the latest master branch: 1. Update DefaultIcon.png to make sure it's the right size and that it doesn't have alpha channel. 2. Enable auto layout, add the following tag to the ios tag in tiapp.xml true 3. With auto layout enabled, fix all deprecated warnings (mostly to do with AUTO property) 4. Any differences in UI behavior for auto layout enabled vs disabled should have tickets filed under the same epic with detailed descriptions so that we can tackle them one by one.

Attachments

FileDateSize
Screen Shot 2015-10-19 at 2.45.05 PM.png2015-10-19T21:51:05.000+000056793
Vertical Layout-Table View.png2015-10-16T23:11:36.000+000058814

Comments

  1. Chee Kiat Ng 2015-10-20

    Thanks [~apetkov]! [~pec1985] when you can, please take a look at each of the above comments and let me know if i should create tickets for each to be addressed :)
  2. Angel Petkov 2015-10-20

    Ill create tickets for these if you want ,ones I'm finished changing all of the kitchen sink. I added the comments just so i remember all the bugs as its just me and you watching the ticket.
  3. Angel Petkov 2015-10-22

    *PR* https://github.com/appcelerator/KitchenSink/pull/81
  4. Chee Kiat Ng 2015-11-19

    [~apetkov] Sorry can you create a PR for master instead? and i believe that as long as your changes and fixes work without auto layout enabled, we can go ahead to review, merge and resolve this ticket. And i'll need you to create new tickets for each auto layout issue you commented. [~pec1985] will address those tickets instead.
  5. Angel Petkov 2015-11-19

    PR pending for the master : https://github.com/appcelerator/titanium_mobile/pull/7475. Linked all the created tickets
  6. Chee Kiat Ng 2015-11-27

    [~apetkov] Hi, sorry if there was some misunderstanding here. I meant creating a PR for the KitchenSink repo Master Branch instead of the KitchenSink repo stable Branch. However, don't close the titanium_mobile.git PR yet. We might consider giving that an update.
  7. Angel Petkov 2015-11-30

    Hi , sorry i should have read more carefully. PR for master : https://github.com/appcelerator/KitchenSink/pull/84
  8. Chee Kiat Ng 2015-12-01

    APPROVED! PR Merged.

JSON Source