[TIMOB-19842] Android: CardView cardPreventCornerOverlap and cardUseCompatPadding should not start with card
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | None |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2015-12-01T04:36:44.000+0000 |
| Affected Version/s | Release 5.1.0 |
| Fix Version/s | Release 5.1.2 |
| Components | Android |
| Labels | n/a |
| Reporter | Fokke Zandbergen |
| Assignee | Ashraf Abu |
| Created | 2015-11-02T09:36:01.000+0000 |
| Updated | 2015-12-02T23:12:48.000+0000 |
Description
I think it's great that we follow the [platform API](https://developer.android.com/reference/android/support/v7/widget/CardView.html) for CardView, but for
cardPreventCornerOverlap and cardUseCompatPadding we don't. On Android there are no properties, but only methods and these don't start with card. To match this in Titanium the properties shouldn't start with this either so our getters and setters match those of the platform.
If in an any way possible this should be in 5.1.0 so we don't have to deprecate properties one release later.
Also related to TIMOB-19802
Backport 5_1_X https://github.com/appcelerator/titanium_mobile/pull/7516
Master and backport PR reviewed.
Verified the fix. Using cardPreventCornerOverlap and cardUseCompatPadding gives us deprecation warning & suggests to use preventCornerOverlap & useCompatPadding instead. Closing. Environment: Appc Studio : 4.4.0.201511241829 Ti SDK : 5.1.2.v20151202061227 Ti CLI : 5.0.5 Alloy : 1.7.26 MAC Yosemite : 10.10.5 Appc NPM : 4.2.2 Appc CLI : 5.1.0 Node: v0.12.27 Nexus 6P - Android 6.0