[TIMOB-20275] "Found incompatible Titanium module" error does not actually say wat the problem is

GitHub Issue	n/a
Type	Bug
Priority	Low
Status	Closed
Resolution	Fixed
Resolution Date	2016-02-18T10:03:33.000+0000
Affected Version/s	titanium 5.0.6
Fix Version/s	node-appc 0.2.34, Release 5.4.0, node-appc 0.2.35, node-appc 0.2.36
Components	Tooling
Labels	n/a
Reporter	Fokke Zandbergen
Assignee	Chris Barber
Created	2016-01-26T21:48:52.000+0000
Updated	2017-03-21T18:42:07.000+0000

Description

When you are using a module that requires a different Titanium SDK version than the one your app is set to it will say:

[DEBUG] Looking for Titanium module id=hyperloop version=latest platform=iphone deploy-type=development
[DEBUG] Found incompatible Titanium module id=hyperloop version=1.1.0 platform=ios,iphone deploy-type=development
[WARN]  Could not find a valid Titanium module id=hyperloop version=latest platform=iphone deploy-type=development
[ERROR] Could not find all required Titanium Modules:
[ERROR]    id: hyperloop	 version: latest	 platform: iphone	 deploy-type: development

There's a few things unclear about this: * None of these messages tell you what the actual problem is. * The one who could is at debug-level and will not be visible to most users. * That same one originates from the validation of the module's minsdk, but its messages has a lot of (version) info, but not about what SDK version is required. So it still doesn't give the user any clue on how to resolve. Suggested fix: * There should be a clear message at the warn/error level that tells the user what SDK the module requires and why these requirements are not met (by showing the app's SDK version).

Comments

Chris Barber 2016-02-10

node-appc PR: https://github.com/appcelerator/node-appc/pull/117 Already merged. v0.2.35 published to NPM. titanium_mobile PR: https://github.com/appcelerator/titanium_mobile/pull/7697
Chris Barber 2016-02-10

This PR is big because I didn't update node-appc in ioslib, so now there's 2 node-appc's in tisdk. If you think I should update ioslib, I can update and publish it, then this PR will go back to a single node-appc.
Chee Kiat Ng 2016-02-11

2 node-appc's that are of different version? If that's the case, update ioslib might be better. And also, if a later version of ioslib is published, will it affect earlier versions of ti sdk?
Chris Barber 2016-02-11

Yes, 2 different node-appc's. I agree, let's update ioslib. Updates to ioslib will not affect older Titanium SDKs. The node modules are baked into the SDK distributions.
Chris Barber 2016-02-12

TiSDK PR https://github.com/appcelerator/titanium_mobile/pull/7697 is ready for review. Couple notes: * This PR has updated all NPM dependencies * The node_modules directory now follows the NPM 3 "perfect tree" layout * It includes the latest node-ios-device which fixes TIMOB-19659
Chee Kiat Ng 2016-02-18

PR merged.
Lee Morris 2017-03-21

Closing ticket as fixed.

JSON Source