Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-20393] iOS: Launch Image Set leaves out required sizes if no (>=8.0) minimum iOS version is set

GitHub Issuen/a
TypeBug
PriorityHigh
StatusClosed
ResolutionFixed
Resolution Date2016-02-15T04:51:56.000+0000
Affected Version/sRelease 5.2.0
Fix Version/sRelease 5.2.0
ComponentsiOS
Labelsn/a
ReporterFokke Zandbergen
AssigneeChris Barber
Created2016-02-12T14:16:03.000+0000
Updated2016-02-16T23:05:37.000+0000

Description

When I build an app without setting a minimum iOS version it defaults to 7.1. In that case, I noticed launch images for iPhone 6+ were missing. This is caused by the following commit: https://github.com/appcelerator/titanium_mobile/commit/105a1fdf72e8f349f71ba10c08c738d9160910ec#diff-f430483233aa01af5b10df8390f9635dR4931 Which is related to the storyboard ticket TIMOB-19694 I don't get the logic for this validation of minIosVer. If that is the minimum iOS version the launch image is supported on, then surely it should be removed when you'd set a *max* iOS version (which I don't even think you can't). If you build to support iOS 7+ then of course the launch images for 8+ *should* be included, right?

Comments

  1. Chris Barber 2016-02-12

    Good catch!
  2. Chris Barber 2016-02-12

    Master PR: https://github.com/appcelerator/titanium_mobile/pull/7719 5_2_X PR: https://github.com/appcelerator/titanium_mobile/pull/7720
  3. Chee Kiat Ng 2016-02-15

    CR and FT Passed. PRs merged!

    Steps to test

    1. *appc new* 2. *appc run -p ios* 3. open the Xcode project in build folder 4. Look inside Assets.xcassets -> LaunchImage

    Expected result

    You should see Retina HD 5.5, Retina HD 4.7 and Retina HD 5.5 Landscape. these were missing before the fix.
  4. Eric Wieber 2016-02-16

    Verified fixed, using: MacOS 10.11.3 (15D21) Studio 4.5.0.201602111338 Ti SDK 5.2.0.v20160216091337 Appc NPM 4.2.3-2 Appc CLI 5.2.0-265 Alloy 1.7.33 Xcode 7.2 (7C68) Built project contains the appropriate launch images, if not using a storyboard. Used the provided steps to test.

JSON Source