Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-20501] Android: Simplify defining shared elements for transitions

GitHub Issuen/a
TypeImprovement
PriorityMedium
StatusOpen
ResolutionUnresolved
Affected Version/sRelease 5.2.0
Fix Version/sn/a
ComponentsAndroid
Labelsn/a
ReporterFokke Zandbergen
AssigneeUnknown
Created2016-03-02T15:29:07.000+0000
Updated2018-02-28T19:54:49.000+0000

Description

While I was writing a [blog post](https://github.com/appcelerator-developer-relations/appc-sample-ti520/blob/master/docs/transitions.md) on the new Activity & Shared Element transitions implemented by TIMOB-19374 I was thinking maybe we can make this easier to use. Why does [addSharedElement()](http://docs.appcelerator.com/platform/latest/#!/api/Titanium.UI.Window-method-addSharedElement) require the transitionName as the second argument when it could just read the transitionName property from the view passed as the first argument? Alternatively we could remove the need to set the transitionName on the view in Window A and simply set that property when the view is passed as the first argument of addSharedElement and the name as the second argument. We could support both but that might make it confusion. I'm for removing the second argument.

Comments

No comments

JSON Source