Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-20537] Regression: Alloy-themed i18n and platform folders no longer work since Ti 5.2.0.GA

GitHub Issuen/a
TypeBug
PriorityCritical
StatusClosed
ResolutionFixed
Resolution Date2016-03-15T05:59:02.000+0000
Affected Version/sRelease 5.2.0
Fix Version/sRelease 5.2.1
ComponentsTooling
Labelsn/a
ReporterAnthony Chung
AssigneeChee Kiat Ng
Created2016-02-29T23:16:20.000+0000
Updated2016-03-24T21:37:16.000+0000

Description

Android 9 patch splash images not showing with Ti SDK 5.2.0 The same splash images fine with Ti SDK 5.1.2, but disappear when switch to 5.2.0. Instead it shows default Appcelerator splash image instead of client splash. To test: - Use http://ticons.fokkezb.nl to generate Android 9 patch splash images for a client image. - compile with Ti.SDK.5.2.0 - error result, shows Appcelerator default splash instead of client Android 9 patch splash. - When switch back to 5.1.2 client 9 patch splash shows. Further notes: - I'm using theme folders in Alloy.

Attachments

FileDateSize
5-1-2-splash-correctpng.png2016-03-01T00:47:50.000+000050810
5-2-0-splash-error.png2016-03-01T00:47:52.000+0000216875
test1.zip2016-03-01T00:47:40.000+0000656768

Comments

  1. Anthony Chung 2016-03-01

    Test project attached.

    - I've included a test project. - Error and correct image screenshots also attached.

    Test

    - Test android 9 patch splash images by switching tiapp.xml from sdk 5.2.0.GA to 5.1.2.GA. - 5.2.0.GA will show error splash image with appcelerator default instead of client 9 patch.

    Build environment:

       Appcelerator Command-Line Interface, version 5.2.0
   Copyright (c) 2014-2016, Appcelerator, Inc.  All Rights Reserved.
   
   Operating System
     Name                        = Mac OS X
     Version                     = 10.11.3
     Architecture                = 64bit
     # CPUs                      = 8
     Memory                      = 16.0GB
   
   Node.js
     Node.js Version             = 0.12.7
     npm Version                 = 2.11.3
   
   Titanium CLI
     CLI Version                 = 5.0.6
     node-appc Version           = 0.2.31
   
   
   Appcelerator Studio, build: 4.5.0.201602170821
   (c) Copyright 2012-2014 by Appcelerator, Inc.  All rights reserved.
   
   Build: jenkins-appcelerator-rcp-master-340 (origin/master)
   Date: 17 February 2016, 08:22:10
  2. Nazmus Salahin 2016-03-01

    Hello, I was able to reproduce this bug with the given steps and test project. When the splash image is in Alloy theme folder the image doesn't pick up as splash image in SDK 5.2.0.GA. Instead it uses the default splash image. But by creating "platform" folder in the project and placing "android-res" in that folder I am able to get the splash image as expected, built by both the SDKs. So the bug seems to be in 5.2.0 SDK related to "theme" folder in the project. *Environment*: *Device info:* Nexux7 (android 6.0.1) *Node.js Version:* 0.12.7 *npm Version:* 2.11.3 *Titanium SDKs:* 5.2.0.GA and 5.1.2.GA *Java Development Kit Version:* 1.8.0_73 *Titanium CLI Version:* 5.0.5
  3. Chee Kiat Ng 2016-03-08

    [~threethirds] We will look into this. Meanwhile, can you try the workaround, putting the images in platform folder as indicated above?
  4. Chris Barber 2016-03-08

    I can't get the 9-patch to work with either 5.1.2.GA or 5.2.0.GA. I tested this with both Alloy 1.7.33 and 1.7.35. I'm 99% sure this is a bug in Alloy, not in the Titanium SDK.
  5. Anthony Chung 2016-03-09

  6. Fokke Zandbergen 2016-03-09

    [~cng] [~cbarber] This is not an Alloy bug, but a regression introduced by a recent change in the Titanium CLI embedded in the SDK. * This feature (ALOY-858) was originally added through a an [Alloy PR](https://github.com/appcelerator/alloy/pull/662) and [Titanium PR](https://github.com/appcelerator/titanium_mobile/pull/6602/files) * The Titanium PR was in part reverted as part of a [Titanium PR](https://github.com/appcelerator/titanium_mobile/commit/105a1fdf72e8f349f71ba10c08c738d9160910ec) that added support for LaunchLogo.png (TIMOB-19684)
  7. Chris Barber 2016-03-09

    \-\-platform\-dir was removed from the Titanium build because it was a hack and it was undocumented. It will not be introduced, so let's hope that ALOY-1365 solves it.
  8. Fokke Zandbergen 2016-03-10

    It might have been a hack, but reverting it now is a breaking change. We need to revert this revert for 5.2.1.GA (won't make RC), then do ALOY-1365 and only then remove the hack again (TIMOB-20543) PR on master: https://github.com/appcelerator/titanium_mobile/pull/7821 PR on 5_2_X: https://github.com/appcelerator/titanium_mobile/pull/7822 Do we need a 5_3_X as well? Or just resolve ALOY-1365 before that?
  9. Chris Barber 2016-03-15

    Fixed by ALOY-1365.
  10. Eric Wieber 2016-03-24

    Verified fixed, by ALOY-1365, using: MacOS 10.11.4 (15E65) Studio 4.5.0.201602170821 Ti SDK 5.2.1.v20160318225121 Appc NPM 4.2.4-2 Appc CLI 5.2.1-21 Alloy 1.8.2 Xcode 7.3 (7D175) The platform folder contents are copied to the correct location; from the Alloy theme folder to the project root platform folder. Tested using the provided test app and other sample apps

JSON Source