Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-20602] Hyperloop: Build doesn't work with 5.4.0

GitHub Issuen/a
TypeBug
PriorityHigh
StatusClosed
ResolutionFixed
Resolution Date2016-04-01T02:29:58.000+0000
Affected Version/sn/a
Fix Version/sRelease 5.4.0
ComponentsHyperloop
Labelshyperloop, ios, qe-5.4.0
ReporterHans Knöchel
AssigneeChee Kiat Ng
Created2016-03-20T15:26:24.000+0000
Updated2016-07-21T22:00:03.000+0000

Description

Currently, Hyperloop does not work with the latest master, because we moved the flag from the section to the root level of the tiapp.xml. Because we will make the main-thread enabled by default and people won't have the flag in new projects, we need to remove the check from the CLI hook.

Comments

  1. Chee Kiat Ng 2016-03-28

    PR here: https://github.com/appcelerator/hyperloop.next/pull/9 PR dependent on related ticket. Once ready, to test: 1. *appc new* using latest SDK on master branch or merged PR on dependent ticket 2. in tiapp.xml, use *true* 3. Include hyperloop module built using this PR. 4. Write a some simple hyperloop code or use it on the https://github.com/appcelerator/hyperloop-examples 5. If you use it on the current master branch of hyperloop-examples repo (not including the PR in below comment), make sure that the platform folder should be in app/ 6. *appc run -p ios* or *appc run -p android* 7. If building on hyperloop-examples repo, you have to use *ti build -p ios* or *ti build -p android*

    Expected result

    App should build correctly and run hyperloop correctly in both ios and android platform. Other test cases include the following changes in tiapp.xml: removing "run-on-main-thread" in the ios section. NOT removing "run-on-main-thread" in the ios section. removing all "run-on-main-thread" properties (this will make the app default to false for run-on-main-thread, and hyperloop won't work)
  2. Chee Kiat Ng 2016-03-31

    Another PR here for the hyperloop-example git: https://github.com/appcelerator/hyperloop-examples/pull/21 Updated so that it supports hyperloop 1.1.2 and SDK 5.4.0.
  3. Chee Kiat Ng 2016-04-01

    PRs merged.
  4. Josh Longton 2016-07-21

    Verified as fixed Hyperloop applications now successfully build with SDK 5.4.0. Tested on: Nexus 5X (6.0.1) Android Emulator (6.0) iPhone 6 plus (9.1) iOS Simulator (9.3) 
Mac OSX El Capitan 10.11.6 Studio: 4.7.0.201607130543 
Ti SDK: 5.4.0.v20160720201924 
Xcode 7.3.1 
Appc NPM: 4.2.7 Appc CLI: 5.4.0-33 Hyperloop:1.2.3 Node v4.4.4 *
Closing Ticket*

JSON Source