[TIMOB-23137] Android: Allow to override default hasCheck drawable for TableViewRow
| GitHub Issue | n/a |
|---|---|
| Type | New Feature |
| Priority | High |
| Status | Open |
| Resolution | Unresolved |
| Affected Version/s | Release 5.2.1 |
| Fix Version/s | n/a |
| Components | Android |
| Labels | n/a |
| Reporter | Fokke Zandbergen |
| Assignee | Unknown |
| Created | 2016-04-01T19:51:56.000+0000 |
| Updated | 2018-02-28T19:55:44.000+0000 |
Description
I'd like to be able to override the default drawable displayed when you set
Ti.UI.TableViewRow.hasCheck on Android:
https://github.com/appcelerator/titanium_mobile/blob/master/android/titanium/src/java/org/appcelerator/titanium/res/drawable/btn_check_buttonless_on.png
Which is selected here:
https://github.com/appcelerator/titanium_mobile/blob/bc85170157d3bebc5de1d61a9fe6e34bce84a8c9/android/modules/ui/src/java/ti/modules/titanium/ui/widget/tableview/TiBaseTableViewItem.java#L73-L89
Ideally I'd put an image with the same name in my app's platform/android/drawable folder to override the default.
*BIG* +1 for this, that icon looks like from the 90's. For now, can we just replace it from newer Android SDK's? EDIT: Seems like Android didn't even change the default one (http://androiddrawables.com/Buttons.html) EDIT2: We deliver some drawables [by default](https://github.com/appcelerator/titanium_mobile/tree/master/android/titanium/src/java/org/appcelerator/titanium/res/drawable), if we remove that folder, wouldn't Android just use it's own defaults and we are future-proof?