[TIMOB-23172] Default min-ios-ver and default enable-launch-screen-storyboard combination rejected by Apple
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | High |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2016-04-11T01:48:39.000+0000 |
| Affected Version/s | Release 5.2.0, Release 5.2.2 |
| Fix Version/s | Release 5.3.0 |
| Components | iOS |
| Labels | n/a |
| Reporter | Fokke Zandbergen |
| Assignee | Fokke Zandbergen |
| Created | 2016-04-08T06:36:32.000+0000 |
| Updated | 2016-05-06T21:57:00.000+0000 |
Description
Templates default to
<enable-launch-screen-storyboard>true</enable-launch-screen-storyboard> since 5.2.0 (TIMOB-19694) but the default <min-ios-ver> is [still 7.1](https://github.com/appcelerator/titanium_mobile/blob/master/iphone/package.json#L21).
This causes an error when you try to upload your app with this default combination to Apple:
!Screen Shot 2016-04-05 at 16.48.40.png|thumbnail!
We should default <min-ios-ver> to 8.0, or at least force it to be 8.0 when a Storyboard is used as launch image, like we do when the app has a WatchOS app:
https://github.com/appcelerator/titanium_mobile/blob/master/iphone/cli/commands/_build.js#L1688-L1693
Attachments
| File | Date | Size |
|---|---|---|
| Screen Shot 2016-04-05 at 16.48.40.png | 2016-04-08T06:34:38.000+0000 | 212242 |
PR on master: https://github.com/appcelerator/titanium_mobile/pull/7925
Can you please make a backport for 5_3_X and 5_4_X, then I'll review and merge. Thanks!
Of course, but there's no 5_4_X branch.. that's master right? Or did you mean 5_2_X? Here is the BP for 5_3_X: https://github.com/appcelerator/titanium_mobile/pull/7930
Verified fixed, using: MacOS 10.11.5 (15F31a) Studio 4.6.0.201604292352 Ti SDK 5.3.0.v20160503133640 Appc NPM 4.2.5-5 Appc CLI 5.3.0-43 Alloy 1.8.7 I am able to successfully upload apps with
<enable-launch-screen-storyboard>true</enable-launch-screen-storyboard>and<min-ios-ver>set to 7.1, the defaults. Templates will validate and upload without error.