[TIMOB-23175] Warning "Android Build Tools X are too new" should not replace < with <=

GitHub Issue	n/a
Type	Bug
Priority	Medium
Status	Closed
Resolution	Fixed
Resolution Date	2016-04-11T04:52:49.000+0000
Affected Version/s	Release 5.2.2
Fix Version/s	Release 5.4.0
Components	Android, Tooling
Labels	n/a
Reporter	Fokke Zandbergen
Assignee	Ashraf Abu
Created	2016-04-08T14:12:07.000+0000
Updated	2016-05-26T19:47:49.000+0000

Description

I'm using SDK 5.2.2.GA which is [known to work](https://github.com/appcelerator/titanium_mobile/blob/5_2_X/android/package.json#L20) with >=17 <23.x. I'm using Android Build Tools 23.0.0 so as expected I get a warning when I run ti info -t android. But, for some reason we [replace](https://github.com/appcelerator/titanium_mobile/blob/master/node_modules/titanium-sdk/lib/android.js#L445) < with <= so the warning is:

Android Issues
  !
     Android Build Tools 23.0.0 are too new and may or may not work with Titanium.
     If you encounter problems, select a supported version with:
        ti config android.buildTools.selectedVersion ##.##.##
      where ##.##.## is a version in /users/fokkezb/Library/Android/sdk/build-tools that is <=23.x

This is confusing since the version I have meets <=23.x. We should not replace < with <=.

Comments

Chris Barber 2016-04-11

Agreed. If we use <=, then https://github.com/appcelerator/titanium_mobile/blame/master/node_modules/titanium-sdk/lib/android.js#L827 would say the tools are supported and the error wouldn't show.
Ashraf Abu 2016-04-11

PR: https://github.com/appcelerator/titanium_mobile/pull/7931 [~cbarber] for your review
Fokke Zandbergen 2016-04-11

With https://github.com/appcelerator/titanium_mobile/pull/7931 and https://github.com/appcelerator/titanium_mobile/blob/master/node_modules/titanium-sdk/lib/android.js#L445 you will now get <<=23.x in the message. Why don't we just the message to use the maxSupported without change: __('\n where ##.##.## is a version in ') + results.sdk.buildTools.path.split('/').slice(0,-1).join('/') + __(' that meets ') + results.sdk.buildTools.maxSupported
Chris Barber 2016-04-11

Fixed verbiage: Master PR: https://github.com/appcelerator/titanium_mobile/pull/7932 5_3_X PR: https://github.com/appcelerator/titanium_mobile/pull/7933
Fokke Zandbergen 2016-04-11

exactly ;)
Lokesh Choudhary 2016-05-26

Verified the fix. Closing. Environment: Appc Studio : 4.6.0.201605180604 Ti SDK : 5.3.0.v20160523083840, 5.4.0.v20160526011354 Ti CLI : 5.0.8 Alloy : 1.8.7 MAC El Capitan : 10.11.4 Appc NPM : 4.2.5-5 Appc CLI : 5.3.0-47 Node: 4.2.2

JSON Source