[TIMOB-23185] TiAPI: Remove Ti.include and advertise workaround
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | High |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2016-11-01T03:17:53.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Release 6.0.0 |
| Components | TiAPI |
| Labels | breaking-change, notable |
| Reporter | Chee Kiat Ng |
| Assignee | Christopher Williams |
| Created | 2016-04-11T03:24:49.000+0000 |
| Updated | 2018-08-06T17:49:10.000+0000 |
Be very sure that is an acceptable workaround for people. The only reason we didn't remove it sooner is that people seemingly had legitimate uses for which this workaround was a PITA. But I could be mis-remembering.
[~fokkezb] any input on this too?
I really can't think of a good use case that justifies keeping this around any longer. People should just convert the files to CommonJS. And we've been deprecating this long enough now.
It will break our Alloy run-time tests, but we'll have to refactor that as part of [~cbarber]'s refactoring of Alloy anyway.
[~cng] It's about time...Things to do: - Remove method from iOS and Android - Add a link to the docs like: {quote} The method "Ti.include" was deprecated in 3.3.0 and removed in 6.0.0. Please use "require" instead and check the migration-guide at http://... {quote} - Validate the affect on Alloy ([~fmiao], can you help with that?) - Include the removal and migration wiki inside our blog-post - before beta, so people can already start migrating it, if they do not already done over the last 2.5 (!) years.
[~msamah] can start working on the android part.
Posted a PR for master/6.1.0: https://github.com/appcelerator/titanium_mobile/pull/8499
oh man. I love this PR and wished it came earlier. I can't have it for 6.1.0 because it's a
remove. and I'm a little reluctant to merge it now because it seems there are some other dependencies like alloy and our window to 6.0.0 is really small now. Can we retain this PR for the next major release?Yeah that's fine. My understanding is that Ti.include **never** worked with alloy, so removing it should not impact alloy.
6_0_X: https://github.com/appcelerator/titanium_mobile/pull/8569 master/6.1.0: https://github.com/appcelerator/titanium_mobile/pull/8499
Cleaning up older fixed issues. If this issue should not have been closed as fixed, please reopen.