Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-23192] Windows: Prompt for selecting wp-sdk option contains unsupported 8.0

GitHub Issuen/a
TypeBug
PriorityNone
StatusClosed
ResolutionFixed
Resolution Date2016-04-14T23:28:45.000+0000
Affected Version/sRelease 5.3.0
Fix Version/sRelease 5.3.0
ComponentsWindows
Labelsqe-5.3.0
ReporterEwan Harris
AssigneeGary Mathews
Created2016-04-12T04:11:02.000+0000
Updated2016-04-19T23:03:32.000+0000

Description

Description

If an invalid value is passed in for --wp-sdk then the CLI will prompt the user to select an SDK, the prompt is below and 8.0 which is unsupported 
Please select a valid wp-sdk value:
 1)  8.0
 2)  8.1
 3)  10.0
*Note* If 8.0 is selected then the build will fail with 
[INFO]  -- The C compiler identification is unknown
[INFO]  -- The CXX compiler identification is unknown
[WARN]  CMake Error at CMakeLists.txt:17 (project):
  No CMAKE_C_COMPILER could be found.
[WARN]  CMake Error at CMakeLists.txt:17 (project):
  No CMAKE_CXX_COMPILER could be found.
[INFO]  -- Configuring incomplete, errors occurred!
See also "C:/Users/Ewan/.titanium/vsbuild/prodclassic/store.x86/CMakeFiles/CMakeOutput.log".
See also "C:/Users/Ewan/.titanium/vsbuild/prodclassic/store.x86/CMakeFiles/CMakeError.log".
or 
2016-04-12T04:09:16.746Z | ERROR  | An uncaught exception was thrown!
No Windows Phone emulators found
2016-04-12T04:09:16.749Z | ERROR  | No Windows Phone emulators found
depending on the chosen target

Steps to reproduce

Run appc run -p windows -T ws-local --wp-sdk 10

Actual result

You will be prompted to choose a valid SDK, with 8.0 in as a possible value which is unsupported

Expected result

Unsupported versions should not be in the prompt

Comments

  1. Chris Barber 2016-04-12

    Windows Hybrid has not been removed and it's about as supported as Mobile Web itself. Windowslib is a library and should return everything it finds. It's up to the Windows build code to filter out unsupported versions. Mobile Web should probably be updated to filter out Windows 10 since only 8.0 and 8.1 were tested.
  2. Gary Mathews 2016-04-14

    titanium_mobile_windows: https://github.com/appcelerator/titanium_mobile_windows/pull/623 5_3_X: https://github.com/appcelerator/titanium_mobile_windows/pull/625
  3. Harry Bryant 2016-04-19

    Verified as fixed, when running appc run -p windows -T ws-local --wp-sdk 10 command, I am prompted to choose between 8.1 / 10.0 only. Tested on: Windows 10 Pro Windows Phone 10.0 & 8.1 (Microsoft Lumia 640 LTE) Appc Studio: 4.6.0.201604180559 Ti SDK: 5.3.0.v20160418111755 Appc NPM: 4.2.5-2 Appc Core: 5.3.0-20 Node: v4.4.2 *Closing Ticket.*

JSON Source