Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-23193] Windows: Change target specific build options into target agnostic build options

GitHub Issuen/a
TypeImprovement
PriorityHigh
StatusClosed
ResolutionFixed
Resolution Date2016-09-15T17:38:40.000+0000
Affected Version/sRelease 5.3.0
Fix Version/sRelease 6.1.0
ComponentsWindows
Labelsqe-5.3.0
ReporterEwan Harris
AssigneeKota Iguchi
Created2016-04-12T04:26:27.000+0000
Updated2017-05-19T22:08:46.000+0000

Description

Description

Currently in the CLI we have a couple of options that are target specific in their naming, namely *\--wp-sdk* and *\--ws-cert*, these options should become target agnostic in their naming as the usage has changed with the introduction of support for Windows 10 and they are no longer specific to a certain target, for example --wp-sdk can be used to change the SDK for a ws-local build, and a cert can be passed into a phone build

Comments

  1. Kota Iguchi 2016-09-12

    So what about introducing * *win-cert* for replacement of *ws-cert* * *win-sdk* for replacement of *wp-sdk* I found another confusing options from the [Command-Line Interface Reference](http://docs.appcelerator.com/platform/latest/#!/guide/Appcelerator_Command-Line_Interface_Reference): * *wp8-publisher-guid* * *wp-product-guid* I'm not sure if *wp8-publisher-guid* is actually used but we might want to change them into *win-publisher-id* and *win-product-guid*.
  2. Ewan Harris 2016-09-12

    That renaming sounds good to me (y). For backwards compatibility with Studio would it be best to keep the existing options around but hidden from -h and then removing them in another release? Maybe hide/deprecate in the version you decide and then remove in 7.0.0? If I remember right I think the hiding of options can be done in config.js. Also, I'll file a ticket now for Studio to adopt these once done As for those two confusing options, I believe they are intended specifically for moving a phone 8 app phone to 8.1, this is probably a holdover from mobile web. I guess maybe we could follow the same process as the above if they're deemed unneeded?
  3. Kota Iguchi 2016-09-13

    Yes, for backwards compatibility I would think we want to deprecate wp-\* and ws-\* options in 6.1.0 and remove it in next major version 7.0.0. * ws-cert → win-cert * wp-sdk → win-sdk * wp-product-guid → win-product-guid For wp8-publisher-guid, I'm not yet sure if we really use it in non-mobieweb build. If it is Windows Phone 8.0 specific option, I think we can deprecate and remove it as of 7.0.0 because we are not supporting Windows Phone 8.0 anymore. Or more proactively, we might want think about deprecating/removing support for Windows Phone 8.1 in 7.0.0? > [~cng]
  4. Kota Iguchi 2016-09-13

    ok confirmed wp8-publisher-guid does not exist. There's wp-publisher-guid instead. This will be renamed to win-publisher-guid.
  5. Kota Iguchi 2016-09-13

    Ah no, renaming wp-publisher-guid to win-publisher-guid seems more confusing because we already have win-publisher-id which is used to specify Windows Publisher ID. I think we want to keep wp-publisher-guid for now and remove it in the version where we remove Windows Phone 8.1 support.
  6. Kota Iguchi 2016-09-14

    https://github.com/appcelerator/titanium_mobile_windows/pull/868
  7. Kota Iguchi 2017-05-09

    We forgot to add fixVersion...this should go to 6.1.0. *Test Case* 
       // testing win-cert
   appc run -p windows --target dist-winstore -l trace --win-cert generated.cer
   
   // testing win-sdk works with 10.0
   appc run -p windows --build-only --target wp-device -l trace --win-sdk 10.0
   
   // testing win-sdk works with specific 10.0 version
   appc run -p windows --build-only --target wp-device -l trace --win-sdk 10.0.10586.0
   
   // win-product-guid
   appc run -p windows --build-only --target wp-device -l trace --win-product-guid f0473be1-c557-4f98-a103-4ba9f453b5b0
  8. Samir Mohammed 2017-05-09

    Verified improvements, tested with commands from [~kota] mentioned above. *Test steps* * Created a titanium project * Ran the following command appc run -p windows --target dist-winstore -l trace --win-cert generated.cer * Followed the prompts * Application was built to the dist folder without any issues * Then ran the following command appc run -p windows --build-only --target wp-device -l trace --win-sdk 10.0 * Application was built successfully * Then ran the following command appc run -p windows --build-only --target wp-device -l trace --win-sdk 10.0.10586.0 * Application built successfully * Then ran the following com appc run -p windows --build-only --target wp-device -l trace --win-product-guid f0473be1-c557-4f98-a103-4ba9f453b5b0 * Application was built without any issues *Environment* APPC CLI: 6.2.0 Windows Mobile 10 device Lumia 640 (10.0.14393) Operating System: Name = Microsoft Windows 10 Pro Version = 10.0.14393 Architecture = 32bit CPUs = 4 Memory = 17034395648 Node.js: Node.js Version = 6.10.1
  9. (deactived) Brian Immel 2017-05-19

    [~kota], does this sound like a good summary for this ticket for the 6.1.0 release note? * Deprecated the commands for wp-* and ws-* * The following replaces the deprecated commands: ** ws-cert > win-cert ** wp-sdk > win-sdk ** wp-product-guid > win-product-guid
  10. Kota Iguchi 2017-05-19

    [~bimmel] Yes, that sounds good (y)

JSON Source