Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-23575] Windows: CLI does not check correct directories when detecting app icons

GitHub Issuen/a
TypeBug
PriorityNone
StatusClosed
ResolutionFixed
Resolution Date2016-07-12T01:36:13.000+0000
Affected Version/sRelease 5.4.0, Release 5.3.0
Fix Version/sRelease 6.0.0
ComponentsWindows
Labelsparity, qe-5.4.0
ReporterEwan Harris
AssigneeGary Mathews
Created2016-06-29T16:40:18.000+0000
Updated2016-09-05T13:52:30.000+0000

Description

Description

When building for Windows Platform currently the following is performed when generating app icons, [as seen in the code](https://github.com/appcelerator/titanium_mobile_windows/blob/master/cli/commands/_build/copy.js#L343-L344)

Check for icon in \app\assets\windows

Check for icon in \

Check for presence of \DefaultIcon-windows.png and generate using this if it exists

Check for presence of \DefaultIcon.png and generate using this if it exists

To be in parity with other platforms the locations should be changed to the following in this order:

Check for icon in \Resources\windows\

Check for icon in \Resources\

Check for \DefaultIcon-windows.png and generate using this if it exists

Check for \DefaultIcon.png and generate using this if it exists

Steps to reproduce

Build a classic Titanium project for the Windows Platform using appc run -p windows -T wp-device --build-only

Copy the icons from <project_dir>\build\windows\Assets\ to <project_dir>\Resources\windows\

Build the project using appc run -p windows -T wp-device --build-only

Copy the icons from <project_dir>\build\windows\Assets\ to <project_dir>\Resources\

Build the project using appc run -p windows -T wp-device --build-only

Actual result

In both step 3 and 5, app icons will be generated

Expected result

In both step 3 and 5, app icons should not be generated as they are located in the correct locations

Comments

  1. Gary Mathews 2016-07-08

    master: https://github.com/appcelerator/titanium_mobile_windows/pull/775
  2. Ewan Harris 2016-09-05

    Verified using: OS: Microsoft Windows 10 Pro 10.0.14393 Appc core: 6.0.0-38 Appc NPM: 4.2.8-6 Ti SDK: 6.0.0.v20160904203840 The correct locations are now checked when building. Closing ticket

JSON Source