Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-23661] Windows: Remove the concept of a selected Windows SDK in ti info

GitHub Issuen/a
TypeImprovement
PriorityNone
StatusClosed
ResolutionFixed
Resolution Date2016-09-15T04:10:09.000+0000
Affected Version/sRelease 5.4.0
Fix Version/sRelease 6.1.0, windowslib 0.4.22
ComponentsWindows
Labelsqe-5.4.0
ReporterEwan Harris
AssigneeKota Iguchi
Created2016-07-20T13:21:27.000+0000
Updated2017-01-20T19:48:10.000+0000

Description

Description

Currently when running appc ti info \-t windows the CLI will print out the below, showing a 'selected' SDK. This is confusing to a user as there is no way for them to actually select an SDK for it to be shown in the output, all selection is done during build time depending on the --wp-sdk value passed in or the OS version on the device/emulator. To stop this confusion (selected) should be removed 
Microsoft (R) Windows Phone SDK
  10.0
    Path                      = C:\Program Files (x86)\Windows Kits\10\
  8.1 (selected)
    Path                      = C:\Program Files (x86)\Microsoft SDKs\Windows Phone\v8.1\

Comments

  1. Kota Iguchi 2016-09-14

    I found that selected property is actually used to decide default Windows SDK as final fallback when no \-\-wp-sdk is specified. But the problem is there's no way to change its value like Ewan noted. I also found that there's windows.wpsdk.selectedVersion config property implemented in [cli/lib/info.js](https://github.com/appcelerator/titanium_mobile_windows/blob/master/cli/lib/info.js#L32). This configuration property seems to be meant to specify default Windows SDK and it should be the way to change "selected" Windows SDK, but seems like this property doesn't work. So I think the real problem in this ticket is, *There's no way to change selected Windows SDK*. *Steps to reproduce (Windows Phone SDK)*

    appc ti info -p windows -json and see which Windows Phone SDK is marked selected

    appc ti config windows.wpsdk.selectedVersion 10.0

    appc ti info -p windows -json and see if Windows 10.0 Phone SDK is marked selected

    *Expected* * Windows 10.0 SDK is selected *Actual* * Windows 10.0 SDK is not selected *Steps to reproduce (Windows SDK)*

    appc ti info -p windows -json and see which Windows SDK is marked selected

    appc ti config windows.sdk.selectedVersion 10.0

    appc ti info -p windows -json and see if Windows 10.0 SDK is marked selected

    *Expected* * Windows 10.0 SDK is selected *Actual* * Windows 10.0 SDK is not selected
  2. Gary Mathews 2016-09-14

    titanium_mobile_windows: https://github.com/appcelerator/titanium_mobile_windows/pull/869 windowslib: https://github.com/appcelerator/windowslib/pull/57 titanium_mobile: https://github.com/appcelerator/titanium_mobile/pull/8383
  3. Samir Mohammed 2017-01-20

    Verified improvement, using appc ti config windows.sdk.selectedVersion i was able to verify the changes in the selected windows SDK. These are the steps i took to verify the changes. *Windows Phone SDK* 1. Used appc ti config windows.wpsdk.selectedVersion 8.1 to change windows phone SDK to 8.1. 2. Used appc ti info -p windows to verify the selected windows phone SDK version was 8.1. 
       Microsoft (R) Windows Phone SDK
     10.0
       Path                      = C:\Program Files (x86)\Windows Kits\10\
     8.1 (selected)
       Path                      = C:\Program Files (x86)\Microsoft SDKs\Windows Phone\v8.1\
    3. Used appc ti config windows.wpsdk.selectedVersion 10.0 to change windows phone SDK to 10.0. 4. Used appc ti info -p windows to verify the selected windows phone SDK version was 10.0. 
       Microsoft (R) Windows Phone SDK
     10.0 (selected)
       Path                      = C:\Program Files (x86)\Windows Kits\10\
     8.1
       Path                      = C:\Program Files (x86)\Microsoft SDKs\Windows Phone\v8.1\
    *Windows SDK* 1. Used appc ti config windows.sdk.selectedVersion 8.1 to change windows SDK to 8.1. 2. Used appc ti info -p windows to verify the selected windows SDK version was 8.1. 3. Used appc ti config windows.sdk.selectedVersion 10.0 to change windows SDK to 10.0. 
       Microsoft (R) Windows Phone SDK
     10.0 (selected)
       Path                      = C:\Program Files (x86)\Windows Kits\10\
     8.1
       Path                      = C:\Program Files (x86)\Microsoft SDKs\Windows Phone\v8.1\
    *Environment* 
       
   Operating System
   Name                        = Microsoft Windows 10 Pro
   Version                     = 10.0.14393
   Architecture                = 64bit
   
    CPUs                      = 4
    
   Memory                      = 17034395648
    
   Node.js
   Node.js Version             = 4.4.4
   npm Version                 = 2.11.3
    
   Titanium SDK
   SDK Version                 =  6.1.0.v20170118152304

JSON Source