Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-23767] Android: Tab icons & label text not visible on default classic 2 tabbed app created using 6.0.0.v20160810073036

GitHub Issuen/a
TypeBug
PriorityCritical
StatusClosed
ResolutionFixed
Resolution Date2016-08-16T09:14:26.000+0000
Affected Version/sRelease 6.0.0
Fix Version/sRelease 6.0.0
ComponentsAndroid
Labelsqe-6.0.0, regression
ReporterLokesh Choudhary
AssigneeHans Knöchel
Created2016-08-11T22:02:20.000+0000
Updated2016-08-16T18:18:41.000+0000

Description

*NOTE: This is s regression. Not seen with 5.4.0.GA*

Steps To Reproduce:

1. Create a default classic 2 tabbed app using the SDK mentioned in the environment. 2. Build it for android device/emulator. 3. Let the app launch.

Actual Results:

1. The tab icons are not visible & the color of the tab icons is black. 2. The label text is not visible on the window as the default color for label is white & no color is specified for the label.

Expected Results:

1. The tab icons & label text should both be visible.

Attachments

FileDateSize
Screen Shot 2016-08-11 at 2.52.53 PM.png2016-08-11T22:02:08.000+000049674

Comments

  1. Chee Kiat Ng 2016-08-15

    [~lchoudhary] Can you check if when did this regression start happening?
  2. Ewan Harris 2016-08-15

    I see this on Windows too. The old app template [explicitly set](https://github.com/appcelerator/titanium_mobile/blob/d822737c19cbb0fa906af8553b96582b4b01e04d/templates/app/default/template/Resources/app.js#L22) the labels color property to #999 the new app template [does not.](https://github.com/appcelerator/titanium_mobile/blob/48045a9d8cf6ce66b48c46b5eec7575ec09f7864/templates/app/default/template/Resources/app.js#L35). Additionally using Ti.UI.setBackgroundColor("#fff"); on Windows sets the tabgroup background color (not the window inside the tab) to white so the tabs can't be seen.
  3. Lokesh Choudhary 2016-08-15

    [~cng], This is a regression. Its not seen in 5.4.0.GA
  4. Ashraf Abu 2016-08-16

    Seems like an issue with the templates?
  5. Ashraf Abu 2016-08-16

    I'm guessing this commit changed that, causing this issue. https://github.com/appcelerator/titanium_mobile/commit/1d0bc0b83728f147bdd25aa0541cab045fc516fa#diff-903c7f44751c42986b9aa032c3143c64 From this TIMOB-23538
  6. Ashraf Abu 2016-08-16

    [~hansknoechel] This is very weird. I tried moving the KS_nav_ui.png to assets/images/KS_nav_ui.png. It works. It's just that assets/images/tab1.png not being picked in Android. Very weird.
  7. Ashraf Abu 2016-08-16

    Oh! It works. I figured out the issue. It's not visible cause it's black on black.
  8. Hans Knöchel 2016-08-16

    If you look to the attached screenshot closely, you see that they are visible, but black. Can you please tint them white? iOS will tint them automatically. And when you already do that, please also change the color to #333 manually. Or let me know if I should take-over since I caused it :-)
  9. Ashraf Abu 2016-08-16

    -[~hansknoechel] Could you update it so that the icons are perhaps grey? Or some other shade that is not white or black?-
  10. Ashraf Abu 2016-08-16

    Ok. I'll try to figure out the tinting. :)
  11. Hans Knöchel 2016-08-16

    PR (master): https://github.com/appcelerator/titanium_mobile/pull/8235 PR (6_0_X): https://github.com/appcelerator/titanium_mobile/pull/8236
  12. Hans Knöchel 2016-08-16

    And I won't say it's a regression, yet, because it's an unreleased feature on master and 6_0_X, but glad we found it! :-)
  13. Ashraf Abu 2016-08-16

    Both PRs merged.
  14. Ashraf Abu 2016-08-16

    A note, there seems to be something going on in the Master branch in 6.1.0 when compiling. Refer to https://github.com/appcelerator/titanium_mobile/pull/8235
  15. Lokesh Choudhary 2016-08-16

    Verified the fix. Tab icons & label text is now visible. Closing. Environment: Appc Studio : 4.7.0.201607250649 Ti SDK : 6.0.0.v20160816021339, 6.1.0.v20160816022751 Ti CLI : 5.0.9 Alloy : 1.9.1 MAC El Capitan : 10.11.6 Appc NPM : 4.2.7 Appc CLI : 6.0.0-24 Node: 4.4.4 Nexus 6 - Android 6.0.1

JSON Source