Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-23769] iOS: Deprecated warnings are thrown in unrelated API's

GitHub Issuen/a
TypeBug
PriorityHigh
StatusClosed
ResolutionFixed
Resolution Date2016-08-15T18:45:07.000+0000
Affected Version/sRelease 5.4.0
Fix Version/sRelease 5.5.0
ComponentsiOS
Labelsdeprecated, ios, qe-5.5.0, regression
ReporterHans Knöchel
AssigneeHans Knöchel
Created2016-08-12T12:19:05.000+0000
Updated2016-09-16T21:08:48.000+0000

Description

Comments

  1. Hans Knöchel 2016-08-15

    Ok, after some more research, I found the reason for the warnings. We reused certain proxies like Ti.UI.iPhone.TableViewCellSelectionStyle and Ti.UI.iPhone.ListViewCellSelectionStyle because they return the same values, so we had a class TiUIiPhoneTableViewCellSelectionStyleProxy that was used by both. Now we deprecated it, so only the warning for TableViewCellSelectionStyle was thrown. What we need to do is to create own classes to throw specific deprecated warnings, until we remove the classes in a later release (probably 7.0.0 or 8.0.0). I guess the same happens for SystemButton but will need to check that as well. PR (master): https://github.com/appcelerator/titanium_mobile/pull/8226 PR (5_5_X): https://github.com/appcelerator/titanium_mobile/pull/8227 Demo: 
       var win = Ti.UI.createWindow();
   
   var test1 = Ti.UI.iPhone.ListViewCellSelectionStyle.NONE;
   var test2 = Ti.UI.iPhone.ListViewStyle.GROUPED;
   var test3 = Ti.UI.iPhone.ListViewScrollPosition.NONE;
   var test4 = Ti.UI.iPhone.ListViewSeparatorStyle.NONE;
   
   win.open();
    *Expected behavior (before)*: Some of the logs show Ti.UI.iPhone.TableView<ProxyName> instead of the actual proxy name. *Expected behavior (after)*: All logs show the correct deprecated warnings that are related to the namespace.
  2. Josh Longton 2016-08-19

    Verified as fixed. Tested on: {noformat} iPhone 6s plus (9.3.1) iPhone 6 (10.0) beta 6 iPhone Simulator (10.0) 
Mac OSX El Capitan 10.11.6 Studio: 4.7.0.201607250649 
Ti SDK: 5.4.0.v20160608165242 
Appc NPM: 4.2.7 Appc CLI: 5.5.0-5 Xcode 7.3.1/8 beta 6 Node: v4.4.4 {noformat} *Closing ticket*
  3. Hans Knöchel 2016-09-16

    I missed the 6_0_X backport: https://github.com/appcelerator/titanium_mobile/pull/8388

JSON Source