[TIMOB-23827] Module ID with underscores not allowed despite Android only platform
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | None |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2016-08-30T18:01:48.000+0000 |
| Affected Version/s | Release 5.4.0 |
| Fix Version/s | Release 6.0.0 |
| Components | Android, Tooling |
| Labels | n/a |
| Reporter | Chris Barber |
| Assignee | Chris Barber |
| Created | 2016-08-25T21:22:31.000+0000 |
| Updated | 2016-09-08T21:24:44.000+0000 |
Description
When trying to create a new module for Android only, the validation says you cannot have an underscore in the module id, despite this being valid for Android. It's iOS that doesn't permit it. The validation logic is bad.
Titanium Mobile master PR: https://github.com/appcelerator/titanium_mobile/pull/8268 Titanium Mobile 6_0_X PR: https://github.com/appcelerator/titanium_mobile/pull/8269
PR merged.
Verified the fix. Creating module with underscore using
appc new -p android& studio worked fine. Closing. Environment: Appc Studio : 4.8.0.201609061702 Ti SDK : 6.0.0.v20160908065418, 6.1.0.v20160907163321 Ti CLI : 5.0.9 Alloy : 1.9.1 MAC El Capitan : 10.11.6 Appc NPM : 4.2.8-6 Appc CLI : 6.0.0-38 Node: 4.4.4 Nexus 6 - Android 6.0.1