[TIMOB-23845] App Compile doesn't trow critical error when compiling fails do to i18n error

GitHub Issue	n/a
Type	Improvement
Priority	Critical
Status	Closed
Resolution	Fixed
Resolution Date	2016-12-12T15:57:51.000+0000
Affected Version/s	n/a
Fix Version/s	n/a
Components	n/a
Labels	n/a
Reporter	Rene Pot
Assignee	Chee Kiat Ng
Created	2016-08-08T15:17:33.000+0000
Updated	2016-12-12T15:57:51.000+0000

Description

When there is an error in the i18n file (invalid xml) the compile doesn't throw an error but a "debug" instead. Default logging doesn't show debug, so it appears compiling fails silently.

[DEBUG] :  Processing i18n file: es/app.xml
[DEBUG] :  Processing i18n file: es/strings.xml
element parse error: Error: invalid tagName:<<<<<< 
@#[line:210,col:1]
element parse error: Error: invalid tagName:<<<<< 
@#[line:210,col:2]
element parse error: Error: invalid tagName:<<<< 
@#[line:210,col:3]
element parse error: Error: invalid tagName:<<< 
@#[line:210,col:4]

Now I know what the issue is, but it would be nice if there was an actual error in the logging. Especially because compile stops at this point

Comments

Sharif AbuDarda 2016-08-09

Hello, Can you provide an instruction on how we can test the issue and successfully regenerate? Thanks.
Rene Pot 2016-08-09

Just make the xml invalid

Sharif AbuDarda 2016-12-12

Hello, The issue is not regeneratable with SDK 6.0.0. Error in strings.xml does not cause the app to faild during compiling. Thanks. Verified:

   Operating System
     Name                        = Mac OS X
     Version                     = 10.11.6
     Architecture                = 64bit
     # CPUs                      = 4
     Memory                      = 8589934592
   Node.js
     Node.js Version             = 4.2.2
     npm Version                 = 2.14.7
   Titanium CLI
     CLI Version                 = 5.0.10
   Titanium SDK
     SDK Version                 = 6.0.0.GA
     SDK Path                    = /Users/gsl001/Library/Application Support/Titanium/mobilesdk/osx/6.0.0.GA
     Target Platform             = android 6.0.1

JSON Source