[TIMOB-23957] iOS: Building app with extension containing swift code doesn't set correct Xcode build settings

GitHub Issue	n/a
Type	Bug
Priority	High
Status	Closed
Resolution	Fixed
Resolution Date	2016-09-29T06:54:24.000+0000
Affected Version/s	Release 5.5.0
Fix Version/s	Release 6.0.0
Components	iOS, Tooling
Labels	n/a
Reporter	Chris Barber
Assignee	Chris Barber
Created	2016-09-28T15:49:04.000+0000
Updated	2018-08-06T17:49:35.000+0000

Description

When building a Titanium iOS app that has an extension that uses Swift, such as a watch app, it doesn't properly remove the Swift related Xcode build settings. It only does it for the main Titanium project, but not the embedded extension targets. Also somewhat related, if the extension's Info.plist has a CFBundleIdentifier of $(PRODUCT_BUNDLE_IDENTIFIER), then it wasn't properly resolving the bundle identifier and causing the build to fail.

Comments

Chris Barber 2016-09-28

TiSDK master PR: https://github.com/appcelerator/titanium_mobile/pull/8375 TiSDK 6_0_X PR: https://github.com/appcelerator/titanium_mobile/pull/8376
Chris Barber 2016-09-28

To test, create a new app, then add a watch app to it. Build for dist-appstore and you should run into the CFBundleIdentifier bug. Then when you upload the built app to the app store via Xcode, you should see the Swift config related errors. You may need to use the old Swift 2 based watch project.
Hans Knöchel 2016-09-28

Thanks for the testing steps. I would prefer to strip out the logging-settings to a different one (and only master), but that should be fine.
Chris Barber 2016-09-28

[~hansknoechel] I moved the OS_ACTIVITY_MODE setting to TIMOB-23959.
Eric Merriman 2018-08-06

Cleaning up older fixed issues. If this issue should not have been closed as fixed, please reopen.

JSON Source