Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-24174] Android: Update TableView/ListView accessory images, fix spacing

GitHub Issuen/a
TypeImprovement
PriorityCritical
StatusClosed
ResolutionFixed
Resolution Date2017-07-25T21:51:29.000+0000
Affected Version/sn/a
Fix Version/sRelease 6.1.2
ComponentsAndroid
Labelsandroid, community, images, merge-6.1.2, notable, qe-6.1.0, tableview
ReporterMichael Gangolf
AssigneeHans Knöchel
Created2016-11-26T12:29:47.000+0000
Updated2017-08-07T23:22:09.000+0000

Description

Adding DENSITY_XXXHIGH images and correcting the size of the other icons: !tablview.png|thumbnail! *Icon sizes:* low: 36px medium: 48px high: 72px xhigh: 96px xxhigh: 144px xxxhigh: 192px PR will also fix setMinimumHeight of the TableViewRow : https://github.com/appcelerator/titanium_mobile/blob/a8aceeaeee02ed9c8ea70c835a0e78960e254a55/android/modules/ui/src/java/ti/modules/titanium/ui/widget/tableview/TiTableViewRowProxyItem.java#L490 TiConvert.toTiDimension is not used on MIN_HEIGHT so the default rows are very small compared to iOS

Attachments

FileDateSize
after.png2017-04-12T14:21:33.000+000041746
before.png2017-04-12T14:21:33.000+000054914
tablview.png2016-11-26T13:35:19.000+000059378
test.png2016-12-08T22:55:43.000+000014618
titanium_check.svg2016-11-26T13:32:50.000+000011761

Comments

  1. Michael Gangolf 2016-11-26

    PR: https://github.com/appcelerator/titanium_mobile/pull/8636 Would like to have some feedback on the images. The "hasChild" could be a bit bigger?
  2. Michael Gangolf 2016-11-26

    updated svg
  3. Michael Gangolf 2016-12-01

    Added more spacing on the right side: !http://migaweb.de/table2.png!
  4. Hans Knöchel 2016-12-02

    [~michael] What is the native behavior here? I'm also wondering why the title have no left-padding by default (we can set it with left, but is this really how it's done natively as well?). *EDIT*: [Looks like](http://www.vogella.com/tutorials/AndroidListView/img/xinteractive10.png.pagespeed.ic.V0cVgp99SN.png) it's native behavior.
  5. Michael Gangolf 2016-12-04

    Thank you, for looking it up! Perhaps adding a different PR with the possibility to add a padding might be a good idea. On the other hand: you can add a label and position it like you want to. Not sure if most people use a table in the default way.
  6. Josh Longton 2016-12-12

    Verified the improvement, the has child/check graphics look correct. Tested on: {noformat} macOS Sierra 10.12.1 Nexus 5X (6.0.1) Nexus 6p (7.0) android emulator (4.4.2, 6.0) Ti SDK: 6.1.0.v20161212041915 Appc NPM: 4.2.8 App CLI: 6.1.0-313 Node v4.6.0 {noformat} *Closing Ticket.*
  7. Hans Knöchel 2017-02-11

    We need to reopen this ticket. There are some serious glitches on some devices (tested with a Nexus 5 GenyMotion simulator): - http://abload.de/image.php?img=bildschirmfoto2017-02neror.png (6.0.1.GA - still missing right margin) - http://abload.de/image.php?img=bildschirmfoto2017-02hrr18.png (6.1.0 - too big, still missing right margin) - http://abload.de/image.php?img=bildschirmfoto2017-02oapwp.png (6.1.0 - too big, still missing right margin) In addition, there is also no title (left) margin on Android, so developers need to "hack" around it by setting a manual left margin on the cells. This should be adapted to match 1:1 the native behavior. And in the same way, we should also update the high-res images for the "disclosure_64.png" asset, they don't currently exist.
  8. Michael Gangolf 2017-02-11

    Almost done: !http://migaweb.de/table_listview.png! (TableView top, ListView bottom) Changes: * Using the same graphics in the ListViewItems * set the correct size * added missing disclosure images * moved the ListViewItem Label a bit more to the right -still searching a way to move the Label inside the TableView- found it, going to make a PR soon
  9. Hans Knöchel 2017-02-11

    Danke Michael! Looking forward to the PR :-)
  10. Michael Gangolf 2017-02-11

    PR: https://github.com/appcelerator/titanium_mobile/pull/8832
  11. Michael Gangolf 2017-02-18

    Fixed the default values on both table/listview: !http://migaweb.de/table_listview2.png! According to https://github.com/android/platform_frameworks_base/blob/82834baa358f55acb542e17da828b2d497cf8332/core/res/res/values/themes.xml#L146 it should be 6dp
  12. Hans Knöchel 2017-02-18

    Very very nice. I'm wondering if the title color is the default as well. That would be the last thing I could think about.
  13. Michael Gangolf 2017-02-18

    Colors were actually the same it was just disabled! I've enabled it and now they look the same
  14. Ben Bahrenburg 2017-07-20

    [~hknoechel] [~lchoudhary] any chance to get this pulled into the 6_1_x branch?
  15. Hans Knöchel 2017-07-25

    Totally! PR: https://github.com/appcelerator/titanium_mobile/pull/9251
  16. Lokesh Choudhary 2017-07-25

    FR passed for 6.1.2 PR PR merged.
  17. Abir Mukherjee 2017-07-26

    [~lchoudhary] Can you please close? I have already checked. The fix is in SDK 6.1.2.v20170726115259.

JSON Source