[TIMOB-24448] iOS: App not compiling due to Ti.Media.systemMusicPlayer
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Critical |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2017-03-08T00:23:09.000+0000 |
| Affected Version/s | Release 6.0.2 |
| Fix Version/s | Release 6.0.3 |
| Components | iOS |
| Labels | n/a |
| Reporter | mikezal1 |
| Assignee | Hans Knöchel |
| Created | 2017-03-02T01:44:07.000+0000 |
| Updated | 2017-03-09T16:45:53.000+0000 |
Description
The app will not compile if " Titanium.Media.appMusicPlayer or the Titanium.Media.systemMusicPlayer" are used in my app. However, it works fine in the simulator or when the iPhone is connected using the LiveView. The app will compile if I code out the line with Titanium.Media.appMusicPlayer.
----
try {
var player = Titanium.Media.systemMusicPlayer;
Ti.API.info(">>>>>>>>>>>>>>>>>>>>>> player.playbackState", player.playbackState);
} catch (e) {
Ti.API.info(e);
}
Ti.API.info("AudioSessionCategory: " + Ti.Media.getAudioSessionCategory());
[ERROR] : ** BUILD FAILED **
[ERROR] : The following build commands failed:
[ERROR] : CompileC build/Intermediates/Triathlon.build/Debug-iphoneos/Triathlon.build/Objects-normal/armv7/MediaModule.o Classes/MediaModule.m normal armv7 objective-c com.apple.compilers.llvm.clang.1_0.compiler
[ERROR] : (1 failure)
PR: https://github.com/appcelerator/titanium_mobile/pull/8857 Details: We wrapped *all* music API's based on the methods that use them. That caused a lot of cross-dependencies between those API's, resulting in a) a messed-up core and b) some edge-cases that cause exactly those issues. This PR removes those macros again, since the AppStore rejections weren't affected to the Music API's but the Camera API's. So we open up the SDK again to make it easier to access certain API's.
FR Passed, using: MacOS 10.12 (16A323) Studio 4.8.1.201612050850 Ti SDK 6.1.0 Appc NPM 4.2.8 Appc CLI 6.1.0 Alloy 1.9.5 Xcode 8.2.1 (8C1002) Tested using the provided code in TIMOB-24448 and TIMOB-24449 as well as running the QE Media Test Suite and submitting an app to the store that uses many ti.media methods/properties. All projects compiled and no errors were encountered
[~hansknoechel], [~vijaysingh]: I believe we need a back port 6_0_X and fixVersion update here.
Backport merged: https://github.com/appcelerator/titanium_mobile/pull/8865
Verified in SDKs 6.0.3.v20170309031327 and 6.1.0.v20170307133328