Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-24569] Windows: Add support for Visual Studio 2017 (26403.03)

GitHub Issuen/a
TypeBug
PriorityHigh
StatusClosed
ResolutionFixed
Resolution Date2017-08-21T09:57:21.000+0000
Affected Version/sRelease 6.1.0
Fix Version/sRelease 6.2.0
ComponentsWindows
Labelsn/a
ReporterGary Mathews
AssigneeKota Iguchi
Created2017-04-10T14:41:19.000+0000
Updated2017-08-22T09:29:39.000+0000

Description

It's possible for vsInfo.vsDevCmd to use the long path with spaces C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\Tools\VsDevCmd.bat instead of the short path 'C:\\PROGRA~2\\MICROS~2\\2017\\COMMUN~1\\Common7\\Tools\\VsDevCmd.bat'. This prevents spawn from executing VsDevCmd.bat.

Comments

  1. Kota Iguchi 2017-04-11

    [~gmathews] Did you get any error output when you use long path? I was not able to reproduce the issue, originally the reason because we are using long path for vsDevCmd is that I have been seeing some VS batch tools including vsvarsall didn't work correctly when you use short path. I am suspecting there has been changes at some point of Windows 10 SDK update...
  2. Kota Iguchi 2017-04-13

    I am not able to build Titanium app with latest Visual Studio 2016 (26403.03). For me build fails at CMake, it seems it doesn't create project files correctly. I tried latest CMake (3.8.0). We might want to check out CMake nightly build.
  3. Kota Iguchi 2017-05-03

    I was able to make this work again by * Uninstall Visual Studio 2017, and then re-install it using [latest installer](https://www.visualstudio.com/thank-you-downloading-visual-studio/?sku=Community&rel=15). * Then setting target platform version to 10.0.10586.0 other than 10.0.15063.0 
           <windows>
         <TargetPlatformVersion>10.0.10586.0</TargetPlatformVersion>
         <TargetPlatformMinVersion>10.0.10586.0</TargetPlatformMinVersion>
       </windows>
    https://github.com/appcelerator/titanium_mobile_windows/pull/959
  4. Ewan Harris 2017-08-21

    Backported in https://github.com/appcelerator/titanium_mobile_windows/commit/32661af33f5238c8fad24bdef268c326aa4ad705
  5. Ewan Harris 2017-08-22

    Verified changes in 6.2.0.v20170821203442

JSON Source