Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-24704] Windows: SDK does not handle TargetPlatformVersion being set to a decimal number

GitHub Issuen/a
TypeBug
PriorityMedium
StatusClosed
ResolutionHold
Resolution Date2020-02-06T09:56:36.000+0000
Affected Version/sRelease 6.1.0
Fix Version/sn/a
ComponentsWindows
Labelsn/a
ReporterEwan Harris
AssigneeSamir Mohammed
Created2017-05-18T11:00:26.000+0000
Updated2020-02-06T09:56:40.000+0000

Description

Description

When setting <TargetPlatformVersion>10.0</TargetPlatformVersion> to 10.0 the CLI will error out with, error comes from [here](https://github.com/appcelerator/titanium_mobile_windows/blob/af913a22799abe89ec66e8adfbc480b3d7bd44d1/cli/commands/_build/generate.js#L212), reason is because typeof this.targetPlatformSdkMinVersion === number 
2017-05-18T10:55:18.742Z | ERROR  | An uncaught exception was thrown!
this.targetPlatformSdkMinVersion.match is not a function
2017-05-18T10:55:18.744Z | ERROR  | this.targetPlatformSdkMinVersion.match is not a function

Steps to reproduce

Set <TargetPlatformVersion>10.0</TargetPlatformVersion> in the windows section of your tiapp

Build

Actual

Build will error out with the above error

Expected

Build should not error out with no information. It should possibly warn about an invalid setting or error out with an informative error

Comments

  1. Kota Iguchi 2019-06-06

    https://github.com/appcelerator/titanium_mobile_windows/pull/1399
  2. Samir Mohammed 2019-11-25

    FR passed, waiting on Jenkins build.
  3. Samir Mohammed 2019-12-06

    Closing ticket, fix verified in SDK version 9.0.0.v20191204090836 Test and other information an be found at: https://github.com/appcelerator/titanium_mobile_windows/pull/1399

JSON Source