[TIMOB-24853] Windows: Update module apiversion in manifest
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | Medium |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2017-06-22T17:44:13.000+0000 |
| Affected Version/s | Release 6.1.0 |
| Fix Version/s | Release 6.1.1 |
| Components | Windows |
| Labels | n/a |
| Reporter | Kota Iguchi |
| Assignee | Kota Iguchi |
| Created | 2017-06-20T02:26:22.000+0000 |
| Updated | 2017-06-23T23:07:15.000+0000 |
Description
The
apiversion in module manifest template needs to be updated due to TIMOB-24786. It goes to 3.
https://github.com/appcelerator/titanium_mobile_windows/pull/1016
[~kota] I bought this up in standup today and it was requested to have this backported to 6_1_X. If you have the time could you possibly make prs for 6_1_X too, no problems if you dont have time, I'll just cherry-pick your commits.
[~eharris] ok, pushed (y) * titanium_mobile master https://github.com/appcelerator/titanium_mobile/pull/9164 * titanium_mobile_windows master https://github.com/appcelerator/titanium_mobile_windows/pull/1016 * titanium_mobile 6_1_X https://github.com/appcelerator/titanium_mobile/pull/9171 * titanium_mobile_windows 6_1_X https://github.com/appcelerator/titanium_mobile_windows/pull/1021
Thanks for that [~kota]!
Verification: This can be done alongside TIMOB-24877. * Build an app with Hyperloop 2.1.2 and 6.1.1.v20170622111134, it should work. * Create a module with
appc new -t timodule -p windows -n myawesomemodule --id com.awesomethe apiversion in windows/manifest should be 3Validated fix with this environment: Node Version: 6.10.3 NPM Version: 3.10.10 Appc CLI: 6.2.2 Appc CLI NPM: 4.2.9 Titanium SDK version: 6.1.1.v20170623141152 Appcelerator Studio, build: 4.9.0.201705302345 Windows OS: 10.0.14393 Windows Device: 10.0.15063 Hyperloop 2.1.2 Beta 3 I installed hyperloop-examples app with no errors. App worked as expected. For the second part of the verification, I built the awesomemodule, and no errors were generated. I checked the manifest file and apiversion was seen to be 3 as expected.