[TIMOB-24925] Windows: Unable to build a module with VS2017

GitHub Issue	n/a
Type	Bug
Priority	Critical
Status	Closed
Resolution	Fixed
Resolution Date	2017-07-17T11:48:52.000+0000
Affected Version/s	Release 6.2.0
Fix Version/s	Release 6.2.0
Components	Windows
Labels	n/a
Reporter	Ewan Harris
Assignee	Kota Iguchi
Created	2017-07-03T14:25:17.000+0000
Updated	2017-07-26T17:22:35.000+0000

Description

When building a module on Windows (after the fix for TIMOB-24923 is in) it will error our with the below, this error occurs when building from Visual Studio too

[WARN]  ComAbc.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl Titanium::Module::Module(class Titanium::Module &&)" (__imp_??0Module@Titanium@@QAA@$$QAV01@@Z) referenced in function "public: __cdecl Com::Abc::Abc(class Com::Abc &&)" (??0Abc@Com@@QAA@$$QAV01@@Z) [C:\Users\ewan\.titanium\vsbuild\awesomemodule\Windows10.ARM\ComAbc.vcxproj]
[WARN]  ComAbc.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: class Titanium::Module & __cdecl Titanium::Module::operator=(class Titanium::Module &&)" (__imp_??4Module@Titanium@@QAAAAV01@$$QAV01@@Z) referenced in function "public: class Com::Abc & __cdecl Com::Abc::operator=(class Com::Abc &&)" (??4Abc@Com@@QAAAAV01@$$QAV01@@Z) [C:\Users\ewan\.titanium\vsbuild\awesomemodule\Windows10.ARM\ComAbc.vcxproj]
C:\Users\ewan\.titanium\vsbuild\awesomemodule\Windows10.ARM\Release\ComAbc.dll : fatal error LNK1120: 2 unresolved externals [C:\Users\ewan\.titanium\vsbuild\awesomemodule\Windows10.ARM\ComAbc.vcxproj]
[WARN]  ComAbc.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl Titanium::Module::Module(class Titanium::Module &&)" (__imp_??0Module@Titanium@@QAA@$$QAV01@@Z) referenced in function "public: __cdecl Com::Abc::Abc(class Com::Abc &&)" (??0Abc@Com@@QAA@$$QAV01@@Z) [C:\Users\ewan\.titanium\vsbuild\awesomemodule\Windows10.ARM\ComAbc.vcxproj]
  ComAbc.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: class Titanium::Module & __cdecl Titanium::Module::operator=(class Titanium::Module &&)" (__imp_??4Module@Titanium@@QAAAAV01@$$QAV01@@Z) referenced in function "public: class Com::Abc & __cdecl Com::Abc::operator=(class Com::Abc &&)" (??4Abc@Com@@QAAAAV01@$$QAV01@@Z) [C:\Users\ewan\.titanium\vsbuild\awesomemodule\Windows10.ARM\ComAbc.vcxproj]
  C:\Users\ewan\.titanium\vsbuild\awesomemodule\Windows10.ARM\Release\ComAbc.dll : fatal error LNK1120: 2 unresolved externals [C:\Users\ewan\.titanium\vsbuild\awesomemodule\Windows10.ARM\ComAbc.vcxproj]

Steps to reproduce

appc new -t timodule --name myawesomemodule --id com.foo

appc run -p windows --build-only

Actual

Build errors out with the warning above

Expected

Build should not error out

Comments

Kota Iguchi 2017-07-11

https://github.com/appcelerator/titanium_mobile_windows/pull/1039
Ewan Harris 2017-07-26

Verified fix in 6.2.0.v20170724075542

JSON Source