Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-24959] Windows: Detect individual versions of Windows 10 SDKs

GitHub Issuen/a
TypeImprovement
PriorityHigh
StatusClosed
ResolutionDone
Resolution Date2019-06-04T23:55:45.000+0000
Affected Version/sRelease 6.2.0
Fix Version/sn/a
ComponentsTooling, Windows
Labelsn/a
ReporterEwan Harris
AssigneeKota Iguchi
Created2017-07-14T12:48:59.000+0000
Updated2019-06-04T23:55:45.000+0000

Description

Description

Currently when detecting Windows 10 SDKs we look for a registry key and then assign a generic '10.0' SDK with some [info](https://github.com/appcelerator/windowslib/blob/3cc8f1aa20c4ba6eb4c65ffca520e7cf4e7d4e55/lib/windowsphone.js#L138-L171) We can improve the individual SDK detection by following a similar method to one of the utility scripts called by VsDevCmd, C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\Tools\vsdevcmd\core\winsdk.bat That files basic flow when searching for an SDK is is one of HKCU\SOFTWARE\Wow6432Node, HKLM\SOFTWARE, or HKCU\SOFTWARE

Get the installation folder using {{reg query \Microsoft\Microsoft SDKs\Windows\v10.0 /v "InstallationFolder"}

Set to WindowsSdkDir

For each directory in <WindowsSdkDir>\include\

- Look for <WindowsSdkDir>\include\<version>\um\Windows.h, if it exists it's a valid SDK I'm not sure what changes would be required to the SDK build process if we switched from using an generic 10.0 to individual SDKs

Comments

  1. Ewan Harris 2017-07-14

    We already do this [https://github.com/appcelerator/windowslib/blob/3cc8f1aa20c4ba6eb4c65ffca520e7cf4e7d4e55/lib/windowsphone.js#L173-L181] but due to TIMOB-24958 I think we might need to expand upon this more and split the SDKs an underlying info out a bit more
  2. Kota Iguchi 2017-10-19

    Can we close this since we have resolved TIMOB-24958?
  3. Kota Iguchi 2019-06-04

    I think this can be closed for now because we already have this feature. Feel free to reopen if that's not the case.

JSON Source