Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-25210] iOS: Cannot submit builds with iOS 11 / Xcode 9 due to missing "Marketing Image"

GitHub Issuen/a
TypeBug
PriorityCritical
StatusClosed
ResolutionFixed
Resolution Date2017-09-19T18:39:34.000+0000
Affected Version/sRelease 6.1.2
Fix Version/sRelease 6.2.1
ComponentsiOS
Labelsappstore, ios, ios11
ReporterHans Knöchel
AssigneeChris Barber
Created2017-08-30T09:59:18.000+0000
Updated2017-10-17T15:14:01.000+0000

Description

I just received feedback from Slack that you currently cannot submit any iOS 11 app due to the error "Missing Marketing Icon - iOS Apps must include a 1024x1024px Marketing Icon in PNG format. Apps that do not include the Marketing Icon cannot be submitted for App Review or Beta App Review.". The issue simply occurs because Apple introduced a new Icon-type in the asset-catalog called "iOS Marketing", which represents a 1024x1024 PNG image. As we already have our DefaultIcon.png, the SDK change would simply grab it and reference the new key in the asset-catalog. Also, we should now enforce the users to specify a "DefaultIcon.png" for iOS 11 distributions and deprecate the manual appicon.png formats. Also see [this Stackoverflow thread](https://stackoverflow.com/questions/44565883/missing-marketing-icon) for more context. *EDIT*: Required asset-catalog object to add:
 {
      "size" : "1024x1024",
      "idiom" : "ios-marketing",
      "filename" : "DefaultIcon.png",
      "scale" : "1x"
}
*EDIT 2*: The following change in our _build.js could allow the app-icon to be received via "appicon-Marketing.png":
'-Marketing':     { height: 1024, width: 1024, scale: 1, idioms: [ 'ios-marketing' ], minXcodeVer: '9.0' }
The same would probably need to be done for the DefaultIcon.png, so we won't need to deprecate anything, yet, just make sure it's supported for both DefaultIcon, non-DefaultIcon, asset-catalog and non-asset-catalog. *EDIT 3*: The above change seems to work (although some others are still missing, might be interesting to investigate later): !Bildschirmfoto 2017-08-30 um 12.19.41.png|thumbnail!

Attachments

FileDateSize
Bildschirmfoto 2017-08-30 um 12.19.41.png2017-08-30T10:21:45.000+00001113321

Comments

  1. Chris Barber 2017-08-30

    master PR: https://github.com/appcelerator/titanium_mobile/pull/9377 6_2_X PR: https://github.com/appcelerator/titanium_mobile/pull/9378
  2. Eric Wieber 2017-08-30

    FR Passed, using: MacOS 10.12.6 (16G24b) Studio 4.9.0.201705302345 Ti SDK 6.2.0.v20170825130234 Appc NPM 4.2.9 Appc CLI 6.2.3 Alloy 1.9.13 Xcode 9.0 (9M202q) I no longer receive the warning about the ios-marketing app icon when submitting an iOS 11 app built with Xcode 9. There is also an appicon-Marketing.png image present in the build.
  3. Eric Wieber 2017-08-30

    Verified in SDK builds 6.2.0.v20170830115907 & 7.0.0.v20170830115844
  4. Chris Barber 2017-09-19

    Fixed bug when specifying a \-\-device\-family of ipad or iphone. Ti SDK master PR: https://github.com/appcelerator/titanium_mobile/pull/9449 Ti SDK 6_3_X PR: https://github.com/appcelerator/titanium_mobile/pull/9450 Ti SDK 6_2_X PR: https://github.com/appcelerator/titanium_mobile/pull/9451
  5. Eric Wieber 2017-09-19

    Bug fix verified in SDK builds 6.2.1.v20170919115451 & 6.3.0.v20170919115627 & 7.0.0.v20170919115520
  6. Hans Knöchel 2017-09-19

    [~ewieber] Should we change to 6.2.1?
  7. Eric Wieber 2017-09-19

    [~hknoechel] yes
  8. Josh Lewis 2017-10-17

    Can this fix be added to the 5x sdk? It just started, and I can't re-write my app now that's due in a few days, many of the modules I'm using arent supported in the latest sdk.

JSON Source