Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-25428] Hyperloop: Android - Block scope declaration errors with node4

GitHub Issuen/a
TypeBug
PriorityHigh
StatusClosed
ResolutionFixed
Resolution Date2017-10-23T11:39:05.000+0000
Affected Version/sHyperloop 2.2.0
Fix Version/sHyperloop 2.2.1
ComponentsAndroid, Hyperloop
Labelsn/a
ReporterEwan Harris
AssigneeEwan Harris
Created2017-10-23T09:59:34.000+0000
Updated2017-10-25T17:53:04.000+0000

Description

Comments

  1. Ewan Harris 2017-10-23

    Master: https://github.com/appcelerator/hyperloop.next/pull/242 2_2_X: https://github.com/appcelerator/hyperloop.next/pull/241
  2. Ewan Harris 2017-10-23

    [~hknoechel] Not sure who you want to review this
  3. Jan Vennemann 2017-10-23

    That would probably be me. Looks good, CR and FR passed, the Android build is working again on Node 4 with these changes!
  4. Hans Knöchel 2017-10-24

    QE-testing: 1. Download the node version mananger "n": npm install -g n 2. Remember which node-version you currently have (node .v) 3. Download to Node 4 with n 4, output like this: 
       Hans-Macbook-Pro:hyperloop.next hknoechel$ n 4
        install : node-v4.8.4
        mkdir : /usr/local/n/versions/node/4.8.4
        fetch : https://nodejs.org/dist/v4.8.4/node-v4.8.4-darwin-x64.tar.gz
    4. Run hyperloop-examples with the old Hyperloop (2.2.0) and confirm it crashes during build 5. Run hyperloop-examples with the new Hyperloop (2.2.1) and confirm it does not crash during build
  5. Abir Mukherjee 2017-10-25

    Validated fix using Han's test steps above. Compile-time failure occurred with Hyperloop 2.2.0. With Hyperloop 2.2.1, no compile-time error was seen, no run-time errors were seen either. The installed app worked as expected. This is the environment: Node Version: 6.10.3 NPM Version: 3.10.10 Mac OS: 10.13 Appc CLI: 6.3.0-master.16 Appc CLI NPM: 4.2.10-2 Titanium SDK version: 6.3.0.v20171018084007 Appcelerator Studio vers 4.10.0 Hyperloop 2.2.0 GA, 2.2.1 Beta 2 Android 7.1.2 Xcode 9.0

JSON Source