[TIMOB-25578] TiAPI: Remove deprecated Geolocation values, only use new ones

GitHub Issue	n/a
Type	Improvement
Priority	High
Status	Closed
Resolution	Fixed
Resolution Date	2019-12-10T11:59:38.000+0000
Affected Version/s	n/a
Fix Version/s	Release 9.0.0
Components	Android, iOS, TiAPI
Labels	parity
Reporter	Christopher Williams
Assignee	Vijay Singh
Created	2017-12-01T21:03:15.000+0000
Updated	2019-12-10T11:59:38.000+0000

Description

http://docs.appcelerator.com/platform/latest/#!/api/GeocodedAddress Specifically, it is insane that we: - have a postalCode property on Android, but zipcode on iOS/Windows. - latitude and longitude are Numbers on iOS/Windows, but String on Android. - have both country_code (on all platforms), and countryCode (only on Android) (we should likely have the same property, and given our naming scheme, it should be called "countryCode") It was deprecated as part of TIMOB-23496 and will now be removed.

Comments

Vijay Singh 2019-11-19

PR (sdk) - https://github.com/appcelerator/titanium_mobile/pull/11350 PR (mocha) - https://github.com/appcelerator/titanium-mobile-mocha-suite/pull/210 Test Case -

   var win = Ti.UI.createWindow({
       backgroundColor: '#fff'
   });
   
   var btn = Ti.UI.createButton({
       title: 'Trigger'
   });
   
   btn.addEventListener('click', function() {
       Ti.API.info('Hello world!');
       Ti.Geolocation.reverseGeocoder('37.773972',  '-122.431297', function(e){
          Ti.API.info('inside  reverse!');
   	   Ti.API.info(JSON.stringify(e));
       });
   });
   
   win.add(btn);
   win.open();

Kota Iguchi 2019-11-21

Cloned off a Windows ticket for this one: TIMOB-27620
Samir Mohammed 2019-11-27

FR Passed, waiting on Jenkins build.
Christopher Williams 2019-12-09

merged to master for 9.0.0
Sohail Saddique 2019-12-10

Build verified. There is now parity between the two platforms. countryCode and postalCode are now being used correctly on both platforms. Ticket closed.

JSON Source