Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-25592] Android CLI: Migration fails if module version does not follow semver (e.g. 1.0), description key overridden

GitHub Issuen/a
TypeBug
PriorityMedium
StatusClosed
ResolutionFixed
Resolution Date2017-12-15T20:49:36.000+0000
Affected Version/sRelease 7.0.0
Fix Version/sRelease 7.0.1
ComponentsAndroid
Labelsn/a
ReporterHans Knöchel
AssigneeHans Knöchel
Created2017-12-09T09:39:51.000+0000
Updated2018-01-02T19:39:51.000+0000

Description

If a module manifest has a version that does not follow semver (e.g. 1.0 instead of 1.0.0), it works fine, but the migration script fails because our semver node module does not detect it properly. We should fix that to make migration less error prone. In addition, noticed by eagle eye [~michael], the description key is overriden by the name. Although it's nothing that breaks anything, it might look confusing on the Git diff, so we should address that as well.

Comments

  1. Hans Knöchel 2017-12-09

    PR (master): https://github.com/appcelerator/titanium_mobile/pull/9670 PR (7_0_X): https://github.com/appcelerator/titanium_mobile/pull/9671
  2. Lokesh Choudhary 2017-12-15

    Found issues commented in the PR's.
  3. Lokesh Choudhary 2017-12-15

    Resolving as 7.0.1 PR is merged. Will work on merging master PR later.
  4. Lokesh Choudhary 2018-01-02

    Verified the fix with SDK 7.0.1.GA & 7.1.0.v20171221131015. Closing. Studio Ver: 5.0.0.201712081732 SDK Ver: 7.1.0.v20171221131015 OS Ver: 10.12.3 Xcode Ver: Xcode 8.3.3 Appc NPM: 4.2.11 Appc CLI: 7.0.1 Daemon Ver: 1.0.1 Ti CLI Ver: 5.0.14 Alloy Ver: 1.10.10 Node Ver: 8.9.1 Java Ver: 1.8.0_101

JSON Source