[TIMOB-26071] Deprecate Ti.SafariDialog, move Ti.WebDialog into the core-modules
| GitHub Issue | n/a |
|---|---|
| Type | Story |
| Priority | None |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2018-06-07T18:51:31.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Release 7.5.0 |
| Components | Android, iOS |
| Labels | n/a |
| Reporter | Hans Knöchel |
| Assignee | Hans Knöchel |
| Created | 2018-05-28T07:40:34.000+0000 |
| Updated | 2018-10-15T15:27:41.000+0000 |
Description
We have [ti.safaridialog](https://github.com/appcelerator-modules/ti.safaridialog) since 5.0.0 to show an embedded web-view natively. Since a while, Android offers the same, so the [ti.webdialog](https://github.com/appcelerator-modules/titanium-web-dialog) was born.
To signalize parity and have all latest features, especially with iOS 12 and Android P coming, we should move ti.webdialog to the SDK and deprecate ti.safaridialog.
PR (ti.safaridialog/master): https://github.com/appcelerator-modules/ti.safaridialog/pull/13 PR (titanium_mobile/master): https://github.com/appcelerator/titanium_mobile/pull/10078 Note: Both Ti.SafariDialog and Ti.TouchID are deprecated. We should remove them from the docs and modules.json in 8.0.0 [~bimmel] The docs for ti.webdialog need to show up in the web-docs as well, similar like we did with ti.identity last year. Can you add it to your repos that are fetched during docs publish? Also, ti.safaridialog docs need to be updated to reflect the deprecation.
[~hknoechel], is this scheduled with the 8.0.0 release?
I am awaiting feedback from Chris, hopefully yes. I'd do the deprecation asap and remove it in 8.0.0.
The deprecations should be done ASAP, so I've merged that PR adding the notice. I'm not sure we have anything like this, but a forward looking document that we can continuously update regarding upcoming deprecations/removals in the next major release would be very helpful for people to see and anticipate changes like this one. For example, we're adding a deprecation notice to the module README on github, but otherwise I'm not sure how people would be notified that this will be happening.
I've merged the addition of ti.webdialog into the core modules packaged with SDK on master (7.4.0). ti.safaridialog is still included as well.
Closing ticket. ti.webdialog can be seen added into the core modules on Master while still ti.safaridialog.