[TIMOB-26314] Android: Add "versionCode" to tiapp.xml template
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | Medium |
| Status | Closed |
| Resolution | Done |
| Resolution Date | 2018-10-29T23:17:23.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Release 7.5.0 |
| Components | Android |
| Labels | android, tiapp |
| Reporter | Michael Gangolf |
| Assignee | Gary Mathews |
| Created | 2018-08-16T20:06:30.000+0000 |
| Updated | 2018-10-29T23:17:26.000+0000 |
Description
Currently the default tiapp.xml doesn't include the versionName or versionCode in the manifest. It will always use versionNumber 1 and versionCode 1 in the AndroidManifest. This will lead to an error when a user uploads an update to the playstore and has to search the documentation or internet to find out where to make these settings.
Adding the versionNumber to the tiapp.xml will give the user a place to start. And by using the number inside the versionName it will automatically stay in sync with the iOS version. Advanced users can still overwrite the versionName with a custom name like before by adding the parameter to tiapp.xml
Scenario:
* android:versionCode is exposed in the block
* user creates an update and can increase the version code
* AndroidManifest will use the versionCode from the block and the
* if a user wants to have a different version number he can add android:versionName to the tiapp.xml (like he would do it today or already has) and it will overwrite the string inside the AndroidManifest
Existing apps with a custom android:versionCode and android:versionName would still use those values.
New apps will use the new android:versionCode from and the normal number as android:versionName
Hello, There is no PR attached. Can you attach here? Thanks.
Sorry, pasted the wrong link. It is: https://github.com/appcelerator/titanium_mobile/pull/10264
removed the versionName part since it is already set in _build
FR Passed. Waiting for merge to be enabled.
PR Merged.
Verified the fix on SDK 7.5.0.v20181004095510. Version code displayed correctly. Closing
Operating System Name = Mac OS X Version = 10.13.6 Architecture = 64bit Node.js Node.js Version = 8.9.1 npm Version = 5.5.1 Titanium CLI CLI Version = 5.1.1 Titanium SDK SDK Version =7.5.0.v20181004095510 Device =Samsung s5 android 6, Pixel 2 XL android 8 emulator.that one was about the GUI in Appcelerator Studio (so you don't even need to edit it by hand).
Ok, yes sorry