[TIMOB-26515] Ti.UI.iOS.NavigationWindow marked as deprecated, but Android missing (7.5.0+)

GitHub Issue	n/a
Type	Improvement
Priority	None
Status	Closed
Resolution	Fixed
Resolution Date	2018-11-07T19:19:39.000+0000
Affected Version/s	Release 7.5.0
Fix Version/s	Release 7.5.0
Components	Android, iOS
Labels	n/a
Reporter	Hans Knöchel
Assignee	Vijay Singh
Created	2018-11-04T15:42:47.000+0000
Updated	2018-11-16T18:25:57.000+0000

Description

When using 7.5.0, the Ti.UI.iOS.NavigationWindow API is marked as deprecated, but the Android parity has not been merged so far. Also it says "deprecated since 7.4.0", whereby it should be 7.5.0. Please either add Android parity in the GA or remove the deprecation until 8.0.0.

Comments

Vijay Singh 2018-11-05

[~hknoechel] thanks for reporting the issue .
Vijay Singh 2018-11-05

[~cwilliams] [~amukherjee] 1. I think we should revert the PR of TIMOB-26060 from 7_5_X as TIMOB-26060 was intended to make parity. 2. We should reopen TIMOB-26060. One more PR for master should be made with necessary change in documents. Any other thought? PR for reverting changes in 7_5_X. PR (7_5_X) - https://github.com/appcelerator/titanium_mobile/pull/10421 PR for titanium mocha - https://github.com/appcelerator/titanium-mobile-mocha-suite/pull/86
Christopher Williams 2018-11-06

This change has been reverted on 7_5_X branch, remains on master (8.0.0) branch.

Samir Mohammed 2018-11-08

*Closing ticket.* Verified fix in SDK version 7.5.0.v20181107165817. No longer see the deprecation error. Tested using the following test case:

   var win2 = Ti.UI.createWindow({
       backgroundColor: 'red',
       title: 'Red Window'
   });
   
   var win1 = Ti.UI.iOS.createNavigationWindow({
      window: win2
   });
   
   var win3 = Ti.UI.createWindow({
       backgroundColor: 'blue',
       title: 'Blue Window'
   });
   
   var button = Ti.UI.createButton({
       title: 'Open Blue Window'
   });
   button.addEventListener('click', function(){
       win1.openWindow(win3, {animated:true});
   });
   
   win2.add(button);
   var button2 = Titanium.UI.createButton({
       title: 'Close Blue Window'
   });
   button2.addEventListener('click', function(){
       win1.closeWindow(win3, {animated:false});
   });
   
   win3.add(button2);
   win1.open();

*Test Environment*

   APPC Studio: 5.1.0.201808080937
   iPhone 6 Sim (iOS 12.1)
   APPC CLI: 7.0.6
   Operating System Name: Mac OS Mojave
   Operating System Version: 10.14.1
   Node.js Version: 8.9.1
   Xcode 10.0

Hans Knöchel 2018-11-16

This was not fully fixed. We still get Ti.UI.iOS.NavigationWindow DEPRECATED in 7.4.0, in favor of Ti.UI.NavigationWindow which seem to be triggered by Alloy I think.
Hans Knöchel 2018-11-16

Discard my previous comment, I was still using a custom built 7.5.0!

JSON Source