Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-26686] Android: Allow Ti.Network.HTTPClient "file" parameter to be set to Ti.Filesystem.File object like iOS

GitHub Issuen/a
TypeImprovement
PriorityLow
StatusClosed
ResolutionFixed
Resolution Date2019-06-10T21:22:40.000+0000
Affected Version/sn/a
Fix Version/sRelease 8.1.0
ComponentsAndroid
LabelsHTTPClient, android, file, parity
ReporterHans Knöchel
AssigneeJoshua Quick
Created2019-01-02T19:08:26.000+0000
Updated2019-06-10T21:22:40.000+0000

Description

*Summary:* On Android, the Ti.Network.HTTPClient "file" property can only be set to a string. On iOS, the "file" property can be set to a string or Ti.Filesystem.File object. We should add File object support on Android for parity. *Community PR:* https://github.com/appcelerator/titanium_mobile/pull/10532

Comments

  1. Keerthi Mahalingam 2019-06-03

    FR passed. Jenkin is failing. Waiting for resolving jenkin's failure.
  2. Christopher Williams 2019-06-04

    merged to master, 8_1_X
  3. Keerthi Mahalingam 2019-06-10

    Verified the fix on sdk 8.1.0.v20190606063903 and 8.2.0.v20190606063615.Works as expected. Closing.
       Name                        = Mac OS X
         Version                     = 10.13.6
         Architecture                = 64bit
       Node.js
         Node.js Version             = 8.9.1
         npm Version                 = 5.5.1
       Titanium CLI
         CLI Version                 = 5.1.1
       Titanium SDK
         SDK Version                 = 8.1.0.v20190606063903 and 8.2.0.v20190606063615
       Device =oneplus 5t android 9
       Emulator =pixel 3xl android 9
       

JSON Source