[TIMOB-26854] iOS: Crash when handling user-activies
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Critical |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2019-06-14T22:17:12.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Release 8.1.0 |
| Components | iOS |
| Labels | n/a |
| Reporter | Hans Knöchel |
| Assignee | Vijay Singh |
| Created | 2019-02-23T19:24:19.000+0000 |
| Updated | 2019-06-14T22:17:12.000+0000 |
Description
When trying to handle user activities, the app experiences a hard crash because the underlaying completion handler passed to the
NSOrderedSet is GC'd due to a memory leak. It can be fixed by properly copy'ing the completion handler.
I scanned other parts of the SDK where this can happen and fixed some more cases as well. I also fixed some duplicate method definitions / leftovers from the SDK 8 Swift support migration.
Pull: https://github.com/appcelerator/titanium_mobile/pull/10725 Test-Case: Run any app that uses handoff / UserActivity API's, like described [here](https://wiki.appcelerator.org/display/guides2/Handoff+User+Activities).
[~vijaysingh] Is there a chance to get this merged into master / 8.1.0 soon? It's approved already and would need to be manually patched on every SDK update right now.
FR passed. No crash observed during handoff. Tested between three devices one iOS 9 and two iOS 12 device. Also tested the handoff immediately after launch on first device and after a while. No crash observed.
Verified on: Mac OS 10.14.3 Ti SDK: 8.1.0.v20190611140242 Appc CLI: 7.0.11 Node: 10.13.0 XCode: 10.2.1