[TIMOB-26901] Android: Launcher icon uses Titanium's default icon instead of "appicon.png" as of 8.0.0

GitHub Issue	n/a
Type	Bug
Priority	Critical
Status	Closed
Resolution	Fixed
Resolution Date	2019-04-29T21:37:33.000+0000
Affected Version/s	Release 8.0.0
Fix Version/s	Release 8.0.1
Components	Android
Labels	android, icon, regression
Reporter	amdolan
Assignee	Ewan Harris
Created	2019-03-11T16:42:58.000+0000
Updated	2019-04-29T21:37:36.000+0000

Description

With this single change, the appicon.png is no longer applied to the android launcher icon. I don't know if iOS is affected by this.

    <icon>appicon.png</icon>

-    <sdk-version>7.5.0.GA</sdk-version>
+    <sdk-version>8.0.0.v20190308114556</sdk-version>

Attachments

File	Date	Size
Screen Shot 2019-03-11 at 11.41.53 AM.png	2019-03-11T16:43:07.000+0000	71851

Comments

Arbind 2019-03-14

Yes, I can also reproduce the issue. There doesn't seem to be any way to have a custom icon, and the titanium-icon is being used. Because of this issue, we can't use this version for Android, and hence I think we should mark this issue as critical.
Ewan Harris 2019-03-15

Thanks for the report folks, I can reproduce this using kitchensink so I'm going to move this across to TIMOB
Ewan Harris 2019-03-15

master: https://github.com/appcelerator/titanium_mobile/pull/10781 8_0_X: https://github.com/appcelerator/titanium_mobile/pull/10780 To test: Build kitchensink-v2 to emulator or device, the icon in the app list should be [this](https://github.com/appcelerator/kitchensink-v2/blob/master/app/assets/android/appicon.png)
Hans Knöchel 2019-03-16

Workaround: Use the DefaultIcon.png in your project directory. The whole <icon> tag should be deprecated these days.
Keerthi Mahalingam 2019-03-18

FR passed.PR merged

Keerthi Mahalingam 2019-03-19

Verified the fix on SDK 8.0.1.v20190318134648 AND 8.1.0.v20190319060446.works fine.

     Name                        = Mac OS X
     Version                     = 10.13.6
     Architecture                = 64bit
     # CPUs                      = 8
     Memory                      = 17179869184
   Node.js
     Node.js Version             = 8.12.0
     npm Version                 = 6.4.1
   Titanium CLI
     CLI Version                 = 5.1.1
   Titanium SDK
     SDK Version                 = 8.1.0.v20190319060446 and 8.0.1.v20190318134648
   Device = samsung s5 android 6
   Emulator = pixel 2xl android 9

JSON Source