[TIMOB-26981] iOS: Module builds broken
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Critical |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2019-04-12T14:50:34.000+0000 |
| Affected Version/s | Release 8.0.0 |
| Fix Version/s | Release 8.0.1 |
| Components | iOS |
| Labels | n/a |
| Reporter | Christopher Williams |
| Assignee | Christopher Williams |
| Created | 2019-04-11T18:00:40.000+0000 |
| Updated | 2019-04-17T13:50:07.000+0000 |
Description
Some of the iOS native module build are completely broken with SDK 8.0.0.
appcelerator.encrytpeddatabase is one that breaks due to the removal of some headers in the packaged SDK's iphone/include folder.
The necessary headers are included in iphone/Classes, but used to have duplicates in iphone/include. we should have redirecting headers placed there.
Additionally, a good deal of the core code moved into the TitaniumKit framework and this headers are inside the framework. We need redirecting headers for those.
Lastly, we should consider some mechanism to automatically include the TitaniumKit framework into the module build. Otherwise module authors have to modify the titanium.xcconfig to add:
DEVELOPER_FRAMEWORKS_DIR = "$(TITANIUM_SDK)/iphone/Frameworks"
FRAMEWORK_SEARCH_PATHS = $(DEVELOPER_FRAMEWORKS_DIR) $(inherited)
merged to master, cherry-picked to 8_0_X. Tested locally by building appcelerator.encrypteddatabase with a locally built SDK.
Closing ticket. Able to build iOS modules on
8.1.0.v20190416065710and8.0.1.v20190415060903.