Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-27358] iOS: Support Apple Developer certificates

GitHub Issuen/a
TypeImprovement
PriorityHigh
StatusClosed
ResolutionFixed
Resolution Date2019-09-09T10:05:09.000+0000
Affected Version/sn/a
Fix Version/sRelease 8.2.0
ComponentsCLI, iOS
Labelsn/a
ReporterEwan Harris
AssigneeEwan Harris
Created2019-08-27T10:44:05.000+0000
Updated2019-09-09T10:05:09.000+0000

Description

Description

Apple has introduced a new "Apple Developer" certificate that encompasses signing for iOS, MacOS, tvOS, and WatchOS applications. I believe this was the root cause of TIMOB-27330. Places we need to update: Titanium CLI/SDK: ioslib@v1 - update cert.js to also scan for "Apple Development" and "Apple Distribution" Daemon: ioslib@v2 & v3: Update the regex to include "Apple Development" and "Apple Distribution" Studio: Might need to update the property it uses from the cert object to display in the UI, currently it's possible for two certs to share an identical name i.e. Ewan Harris (EH123J4ST56), so only one appears to be added to the cert list, the only way to differentiate is via the fullname i.e. Apple Distribution: Ewan Harris (EH123J4ST56)} vs {{iPhone Distribution: Ewan Harris (EH123J4ST56)

Comments

  1. Ewan Harris 2019-08-27

    This might have an impact on Studio as it might need to use a different name on the certs
  2. Ewan Harris 2019-08-27

    ioslib 1_7_X (included in SDK): https://github.com/appcelerator/ioslib/pull/93 ioslib 2_X (included in appc cli): https://github.com/appcelerator/ioslib/pull/94 ioslib master: https://github.com/appcelerator/ioslib/pull/95 Once 1_7_X is merged work can start on the SDK support. Once 2_X is merged a new CLI will need to be published
  3. Ewan Harris 2019-08-29

    titanium_mobile: https://github.com/appcelerator/titanium_mobile/pull/11188 Need to file a ticket to have Studio prefer "fullname"
  4. Chris Barber 2019-08-29

    Published ioslib 1.7.12, 2.5.1, and 3.2.2.
  5. Samir Mohammed 2019-09-03

    FR Passed, waiting on Jenkins build.
  6. Christopher Williams 2019-09-03

    Merged to master for 8.2.0
  7. Lokesh Choudhary 2019-09-03

    Verified the fix in SDK 8.2.0.v20190903100931. Closing.
  8. Samir Mohammed 2019-09-05

    Re-opening. When distributing with an iPhone cert the apple cert seems to be used instead. 
       [TRACE] error: Provisioning profile "Any App AppStore Distribution" doesn't include signing certificate "Apple Distribution: Michael Asher (WY35J6ST95)". (in target 'aaaa' from project 'aaaa')
    *Test Steps*

    Have both iphone and Apple Certs

    Run the following command 

       appc run -p ios -T dist-appstore -I 13.0 -l trace

    Select the iphone distribution cert

  9. Chris Barber 2019-09-05

    [~smohammed] It sounds like you need to add the Apple Distribution cert to the provisioning profile.
  10. Ewan Harris 2019-09-05

    Ok lets try this again PR: https://github.com/appcelerator/titanium_mobile/pull/11198 I need to file a PR to update the watchos sample as that is outdated and doesn't have the required things to pass along provisioning profiles correctly
  11. Samir Mohammed 2019-09-06

    PR merged for Master, will be merged in 8_3_X at a later date.
  12. Samir Mohammed 2019-09-09

    *Closing ticket* Improvement verified in SDK version 8.2.0.v20190906140307. *Test and other information can be found at:* https://github.com/appcelerator/titanium_mobile/pull/11198 https://github.com/appcelerator/titanium_mobile/pull/11188

JSON Source