[TIMOB-27375] Android: launch activity no longer throws create & start lifecycle events as of 8.0.1
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | n/a |
| Status | Open |
| Resolution | Unresolved |
| Affected Version/s | Release 8.0.1 |
| Fix Version/s | n/a |
| Components | Android |
| Labels | android, engSchedule |
| Reporter | Joe Falcone |
| Assignee | Yordan Banev |
| Created | 2019-08-31T05:41:32.000+0000 |
| Updated | 2019-09-17T12:16:35.000+0000 |
Description
For historical reasons, we had incorporated receiving the 'start' event from the launch activity into how our app unfolds.
Let's look at a startup log for an app that just creates and opens a window.
app.js:
if (Ti.Platform.osname === 'android') {
var launcher = Ti.Android.currentActivity;
launcher.addEventListener('create', function(e) {
Ti.API.info('+++ LAUNCHER onCreate');;
});
launcher.addEventListener('destroy', function(e) {
Ti.API.info('+++ LAUNCHER onDestroy');
});
launcher.addEventListener('pause', function(e) {
Ti.API.info('+++ LAUNCHER onPause');
});
launcher.addEventListener('resume', function(e) {
Ti.API.info('+++ LAUNCHER onResume');
});
launcher.addEventListener('start', function(e) {
Ti.API.info('+++ LAUNCHER onStart: ');
});
launcher.addEventListener('stop', function(e) {
Ti.API.info('+++ LAUNCHER onStop');
});
launcher.addEventListener('newintent', function(e) {
Ti.API.info('+++ LAUNCHER onNewIntent: ' + JSON.stringify(e));
});
}
var window = Ti.UI.createWindow({
backgroundColor: 'white',
layout: 'vertical'
});
window.open();
1. If you are going to change a significant behavior that has been around for many years, it is a good idea to document it at least in the release notes. Assuming that no one is depending on it or using it for whatever reason is pretty dangerous. It cost me hours of debugging to realize what was really going on when our app was stuck on the splash screen. I don't work for some mega-corporation so this is time out of my own pocket. 2. We waited for 'start' for historical reasons (going back years - we've been using Titanium since 2012). Years ago, there were issues with spinning up certain modules before the app was really well and truly running so we found that waiting for 'start' was a safe way of doing this. 3. Again for historical reasons, our app startup using lifecycle events was completely separate for iOS and Android. So this is good that we can fold them together.
I hear you. In Titanium 8.0.x, we've refactored the app startup/resume/exit behavior to resolve some design issues we've had and to improve intent/resume handling. The most noteworthy changes are the below. * [TIMOB-26075] * [TIMOB-26538] * [TIMOB-26555] * [TIMOB-26850]