[TIMOB-27403] CLI: Semantic colors file lookup does not work correctly in classic applications

GitHub Issue	n/a
Type	Bug
Priority	Medium
Status	Closed
Resolution	Fixed
Resolution Date	2019-10-04T13:45:36.000+0000
Affected Version/s	Release 8.2.0
Fix Version/s	Release 8.2.1
Components	CLI, iOS
Labels	engSchedule
Reporter	Ewan Harris
Assignee	Ewan Harris
Created	2019-09-16T13:03:56.000+0000
Updated	2019-10-04T13:45:36.000+0000

Description

When looking up the semantic.colors.json file for classic applications we look in Resources/iphone this isn't really the place we want to find it. We want to also look in Resources as it's intended to be cross-platform

Steps to reproduce

1. Get the project from https://github.com/ewanharris/darkmode-example-classic 2. Build to an iOS 13 sim/device 3. Toggle dark mode

Actual

App has white window and black label always

Expected

App should change between a yellow window with a red label (light mode) and green window with a pink label (dark moe)

Comments

Ewan Harris 2019-09-16

master: https://github.com/appcelerator/titanium_mobile/pull/11217 8_2_X: https://github.com/appcelerator/titanium_mobile/pull/11218
Ewan Harris 2019-09-16

Not sure whether we want this in 8.2.0 or 8.2.1 so leaving fixVersion blank for now
Christopher Williams 2019-09-17

merged to master. Holding on 8_2_X PR for 8.2.0.GA to go out first.
Christopher Williams 2019-09-20

merged to 8_2_X
Samir Mohammed 2019-10-04

Closing ticket, fix verified SDK version 8.3.0.v20191003144543 and 8.2.1.v20191003075717. Test and other information cab be found at: master: https://github.com/appcelerator/titanium_mobile/pull/11217 8_2_X: https://github.com/appcelerator/titanium_mobile/pull/11218 Note* user must be using Xcode 11 build tools.

JSON Source