[TIMOB-27413] iOS: Window hideShadow and shadowImage property doesn't works on iOS 13

GitHub Issue	n/a
Type	Bug
Priority	Critical
Status	Closed
Resolution	Fixed
Resolution Date	2019-10-04T18:14:12.000+0000
Affected Version/s	Release 8.2.0
Fix Version/s	Release 8.2.1
Components	iOS
Labels	engSchedule, ios, regression
Reporter	Jorge Macias Garcia
Assignee	Vijay Singh
Created	2019-09-23T12:01:40.000+0000
Updated	2020-10-09T09:45:47.000+0000

Description

There was a trick to remove the shadow on navigation bar. It consisted on set a image of the same color as the background and set it to *barImage* property and set *hideShadow* to true. It is working with 8.2.0.GA on iOS 13 < but not on iOS 13. tss:

"Window" : {
  navTintColor: 'black',
  translucent: false,
  hideShadow: true,
  barImage: '/images/barBackground.png', //white imagen 1px size
}

This line could be related with: https://github.com/appcelerator/titanium_mobile/blob/11aef9cc1069c395e8f9a45570633e40dd80f76e/iphone/TitaniumKit/TitaniumKit/Sources/Modules/TiUIWindowProxy.m#L442 On the screenshot attached: - iOS 13 on the left side. - iOS 12 on the right side.

Attachments

File	Date	Size
bgImage.png	2019-09-25T19:03:27.000+0000	2476
image.png	2019-09-23T11:59:52.000+0000	56260
shadowImage.png	2019-09-25T19:03:31.000+0000	744

Comments

Vijay Singh 2019-09-24

PR (master) - https://github.com/appcelerator/titanium_mobile/pull/11239 PR (8_2_X) - https://github.com/appcelerator/titanium_mobile/pull/11240 Test Case 1 (hide shadow) -

   var win = Ti.UI.createWindow({
       backgroundColor: '#ffff',
       navTintColor: 'black',
       translucent: false,
       hideShadow: true,
       barImage: 'bgImage.png',
   });
   
   var navWin = Ti.UI.createNavigationWindow({
   	window: win
   
   });
   
   var btn = Ti.UI.createButton({
       title: 'Trigger'
   });
   
   btn.addEventListener('click', function() {
       Ti.API.info('Hello world!');
   });
   
   win.add(btn);
   navWin.open();

Test Case 2 - (shadow image)

   var win = Ti.UI.createWindow({
       backgroundColor: '#ffff',
       navTintColor: 'black',
       translucent: false,
       shadowImage: 'shadowImage.png',
       barImage: 'bgImage.png',
   });
    
   var navWin = Ti.UI.createNavigationWindow({
   	window: win
    
   });
    
   var btn = Ti.UI.createButton({
       title: 'Trigger'
   });
    
   btn.addEventListener('click', function() {
       Ti.API.info('Hello world!');
   });
    
   win.add(btn);
   navWin.open();

Satyam Sekhri 2019-09-27

FR Passed. Waiting on Jenkins build for 8_2_X branch.
Christopher Williams 2019-10-02

merged to master and 8_2_X
Satyam Sekhri 2019-10-04

Verified On: Mac OS: 10.14.5 SDK: 8.2.1.v20191003075717, 8.3.0.v20191003144543 Appc CLI: 7.1.1 JDK: 1.8.0_162 Node: 10.5.0 Studio: 5.1.4.201909061933 Xcode: 11.0 Device: iPhone X(13.0), iPhone 7Plus(12.3.1)

JSON Source