[TIMOB-27436] Images that end in "-dark" are no longer working after updating to 8.2.x SDK on iOS
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | None |
| Status | Closed |
| Resolution | Not Our Bug |
| Resolution Date | 2020-04-10T21:00:05.000+0000 |
| Affected Version/s | Release 8.2.0 |
| Fix Version/s | n/a |
| Components | iOS |
| Labels | engSchedule, griffin-app |
| Reporter | Brenton House |
| Assignee | Vijay Singh |
| Created | 2019-10-02T15:40:49.000+0000 |
| Updated | 2020-04-10T21:10:44.000+0000 |
Description
On iOS, if you have images that end in "-dark", they are no longer working after updating to 8.2.x SDK. The SDK now believes that these are images for use with iOS Dark Mode.
Thats native iOS behavior. Users should rename their images or the CLI should detect files with "-dark" that don't have a base (light) file and throw an error on build time.
Is this really the case for native iOS objective-c or swift development? Any images that end in "-dark" are automatically assumed to have been created for a "dark" mode? I thought this was a Titanium implementation that then assigned it iOS dark/light mode images.
It seems that if you specify an image that ends in "-dark", such as "myimage-dark.png" it would look for "myimage-dark-dark.png" and "myimage-dark-light.png".